Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Melanosome Membrane #5865

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Add Melanosome Membrane #5865

merged 1 commit into from
Jan 31, 2025

Conversation

HexapodPhilosopher
Copy link
Contributor

@HexapodPhilosopher HexapodPhilosopher commented Jan 30, 2025

Brief Description of What This PR Does

Replaces Melanosome model with a membrane-bound one.
Adjusts some text.

Related Issues

closes #5861

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.1 milestone Jan 31, 2025
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improved model, it looks good.
I'm not fully sure about the text changes, but let's just go with them (it's probably fine for the radioactive chunk to have a slightly longer name, probably no one will pay any attention to that change).

@hhyyrylainen hhyyrylainen merged commit 2b32137 into master Jan 31, 2025
4 checks passed
@hhyyrylainen hhyyrylainen deleted the MelanosomeMembrane branch January 31, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Modify the melanosome model to properly fit 2 hexes instead of forcing streching
2 participants