Thank you for contributing to Thrive.

Before your contribution can be accepted, you need to sign our CLA.
You can sign it, and find more info about it, here: https://dev.revolutionarygamesstudio.com/cla

Once your contribution has been accepted you can ask to be included in the credits (https://wiki.revolutionarygamesstudio.com/wiki/Team_Members) and you can apply to join the team and use this work as a sample: https://revolutionarygamesstudio.com/application/

I can't say I'm a big fan of working around an engine bug like this... Especially as this doesn't prevent the slider change events from actually being emitted (or at least I assume so). Does this even prevent the slider from moving without MP? I think that's a very important part to keep.

I'm not sure about the change events being emitted, but the slider is still unable to move without MP due to this code:

int cost = Math.Abs(rigidity - intRigidity) * costPerStep;

if (cost > Editor.MutationPoints)
{
    ...
    rigidity = intRigidity > rigidity ? intRigidity - stepsLeft : intRigidity + stepsLeft;
}

Which can be found in the file src\microbe_stage\editor\CellEditorComponent.cs starting on line 890.

That makes the code much more likely to have bugs, we aren't preventing the slider from attempting to move. Still at best this PR is a hack around an engine issue in my opinion.

Once when I was tackling #3991 I tried to delete this code and make dynamic MP decide if the slider can still move (but failed). I prefer that we never disable the sliders but fix that logic mentioned above

but the slider is still unable to move without MP due to this code

Once when I was tackling #3991 I tried to delete this code and make dynamic MP decide if the slider can still move (but failed). I prefer that we never disable the sliders but fix that logic mentioned above

I suppose, yes, that'll actually make sense. We just need a way to prevent dragging it in a direction that would cause negative MP, but allow dragging in a direction that gives back MP.

I'm not sure if this is exactly what you mean, but I was also playing around with the code and found out that if you write:

int cost = (Math.Abs(rigidity) - Math.Abs(intRigidity)) * costPerStep;

The slider can not go any farther into its domain (positive to farther positive) but can still go back even to the opposite domain as long as the player has enough MP to do so.

I didn't put it in the PR because I didn't want to do any extra that what the issue reported.