Improved rigidity slider handling again #3588
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this's got bugs in multicellular. Wait until I figure this out. |
|
It works well actually... |
| @@ -598,6 +598,7 @@ public override void OnEditorSpeciesSetup(Species species) | |||
| // that just marks things dirty and we update our stats on the next _Process call) | |||
| Membrane = Editor.EditedCellProperties!.MembraneType; | |||
| Rigidity = Editor.EditedCellProperties.MembraneRigidity; | |||
| originalRigidity = (int)Math.Round(Rigidity * Constants.MEMBRANE_RIGIDITY_SLIDER_TO_VALUE_RATIO); | |||
There was a problem hiding this comment.
Storing the original value like this goes against the dynamic MP, so having just the rigidity not follow the way everything else is handled in the editor is not the right design in my opinion.
|
I tried but was defeated by the dynamic MP. I don't even know if a bug is because dynamic MP or because I wrote it. Closing this. |
|
I think I'll open sometime soon a discussion topic on the dev forum about the dynamic MP and if there is enough willingness to do a system overhaul on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Suppresses #1533
Closes #3452
Fixes #3203
Progress Checklist
Note: before starting this checklist the PR should be marked as non-draft.
break existing features:
https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
(this is important as to not waste the time of Thrive team
members reviewing this PR)
styleguide.
Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.