Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider handling agaaaaaaaaaain #3700

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Slider handling agaaaaaaaaaain #3700

merged 4 commits into from
Aug 17, 2022

Conversation

84634E1A607A
Copy link
Contributor

@84634E1A607A 84634E1A607A commented Aug 14, 2022

Brief Description of What This PR Does

This time used a linear algo to calculate the end position. This doesn't rely on the initial value so it should be fine.
Also fixed a bug where float to int cast is directly using (int) instead of Math.Round(), causing strange loss.

Related Issues
Fixes #3639
alleviates #1533 (?) let's leave that open though as it is an issue tracking a Godot bug we are interested in having fixed -hhyyrylainen
Fixes #3203
Closes #3452

Needs test: #3562

Progress Checklist

Note: before starting this checklist the PR should be marked as non-draft.

  • PR author has checked that this PR works as intended and doesn't
    break existing features:
    https://wiki.revolutionarygamesstudio.com/wiki/Testing_Checklist
    (this is important as to not waste the time of Thrive team
    members reviewing this PR)
  • Initial code review passed (this and further items should not be checked by the PR author)
  • Functionality is confirmed working by another person (see above checklist link)
  • Final code review is passed and code conforms to the
    styleguide.

Before merging all CI jobs should finish on this PR without errors, if
there are automatically detected style issues they should be fixed by
the PR author. Merging must follow our
styleguide.

@hhyyrylainen hhyyrylainen requested review from a team August 14, 2022 08:52
@hhyyrylainen hhyyrylainen added this to the Release 0.5.10 milestone Aug 14, 2022
Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code standpoint this change looks fine to me. Let's wait some more time if we can get someone to playtest this.

Copy link
Member

@hhyyrylainen hhyyrylainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a quick test and this seems to work fine enough so I'll merge this as it doesn't look like anyone else will test this.

@hhyyrylainen hhyyrylainen merged commit 037b070 into master Aug 17, 2022
@hhyyrylainen hhyyrylainen deleted the slider_handling_agaaiin branch August 17, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants