-
Notifications
You must be signed in to change notification settings - Fork 3
fix: specify node version #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request involve an update to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
package.json (1)
12-12: Consider using a more specific version range.While
18.xworks, consider using a more specific range like18.17.0or^18.17.0to ensure consistent builds across all environments. This version is the minimum supported by Next.js 15.- "node": "18.x" + "node": "^18.17.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
11-13: LGTM! Good addition for Heroku compatibility.
Adding the engines field with Node.js 18.x is the correct solution for fixing Heroku buildpack issues. This version is compatible with your Next.js and React dependencies.
Problem
It is not building on heroku buildpacks
Change
Specify node version for build
Summary by CodeRabbit
New Features
Chores