Sharing reports not possible any more #354

Rello · Jun 15, 2023 · 26ddbe1 · 26ddbe1
1 parent ad2dd45
commit 26ddbe1
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 9 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,9 +1,13 @@
 # Changelog
 
+## 4.9.4 - 2023-06-15
+### Fixed
+- NC 27 Uncaught (in promise) TypeError: OC.Apps is undefined #356
+
 ## 4.9.3 - 2023-05-27
 ### Fixed
 - Sharing reports not possible any more #354
-- 
+
 ## 4.9.2 - 2023-05-26
 ### Fixed
 - Sharing reports not possible any more #354

diff --git a/css/style.css b/css/style.css
@@ -166,7 +166,8 @@
 
 .sidebarInput {
     width: 200px;
-    border: 2px solid var(--color-border-dark) !important;
+    border: 1px solid var(--color-border-dark) !important;
+    border-radius: var(--border-radius-large);
 }
 
 .sidebarHeaderClosed {

diff --git a/css/style.scss b/css/style.scss
@@ -182,7 +182,8 @@
 }
 .sidebarInput {
   width: 200px;
-  border: 2px solid var(--color-border-dark) !important;
+  border: 1px solid var(--color-border-dark) !important;
+  border-radius: var(--border-radius-large);
 }
 
 .sidebarHeaderClosed {

diff --git a/js/advanced.js b/js/advanced.js
@@ -34,12 +34,12 @@ OCA.Analytics.Advanced = {
             if (document.getElementById('advanced').value === 'false') {
                 if (appsidebar.dataset.id === '') {
                     document.getElementById("sidebarClose").addEventListener("click", OCA.Analytics.Advanced.hideSidebar);
-                    OC.Apps.showAppSidebar();
+                    appsidebar.classList.remove('disappear');
                 }
             } else {
                 OCA.Analytics.UI.hideElement('analytics-intro');
                 OCA.Analytics.UI.showElement('analytics-content');
-                OC.Apps.showAppSidebar();
+                appsidebar.classList.remove('disappear');
             }
             appsidebar.dataset.id = datasetId;
             appsidebar.dataset.type = datasetType;
@@ -110,7 +110,7 @@ OCA.Analytics.Advanced = {
 
     hideSidebar: function () {
         document.getElementById('app-sidebar').dataset.id = '';
-        OC.Apps.hideAppSidebar();
+        document.getElementById('app-sidebar').classList.add('disappear');
         document.querySelector('.tabHeaders').innerHTML = '';
         document.querySelector('.tabsContainer').innerHTML = '';
     },

diff --git a/js/sidebar.js b/js/sidebar.js
@@ -32,12 +32,12 @@ OCA.Analytics.Sidebar = {
             if (!OCA.Analytics.isAdvanced) {
                 if (appsidebar.dataset.id === '') {
                     $('#sidebarClose').on('click', OCA.Analytics.Sidebar.close);
-                    OC.Apps.showAppSidebar();
+                    appsidebar.classList.remove('disappear');
                 }
             } else {
                 OCA.Analytics.UI.hideElement('analytics-intro');
                 OCA.Analytics.UI.showElement('analytics-content');
-                OC.Apps.showAppSidebar();
+                appsidebar.classList.remove('disappear');
             }
             appsidebar.dataset.id = datasetId;
             appsidebar.dataset.type = datasetType;
@@ -135,7 +135,7 @@ OCA.Analytics.Sidebar = {
 
     close: function () {
         document.getElementById('app-sidebar').dataset.id = '';
-        OC.Apps.hideAppSidebar();
+        document.getElementById('app-sidebar').classList.add('disappear');
         document.querySelector('.tabHeaders').innerHTML = '';
         document.querySelector('.tabsContainer').innerHTML = '';
     },