Fix some minor inconsistencies in LAPACK(E)_[cz]gesvdq#436
Merged
Conversation
For LAPACKE_cgesvdq, align datatype of `rwork` with lapacke.h and callsite in LAPACKE_cgesvdq_work; both of the latter use `float* rwork`, so there's no need to calculate with doubles that only get downcast anyway. Similarly, make the signature of lapacke_zgesvdq_work consistent across lapack.h (modified here), the fortran side and lapacke_zgesvdq_work, see: https://github.com/Reference-LAPACK/lapack/blob/v3.9.0/LAPACKE/src/lapacke_zgesvdq_work.c#L42 https://github.com/Reference-LAPACK/lapack/blob/v3.9.0/SRC/zgesvdq.f#L422
Contributor
|
Thanks! And sorry for overlooking your previous PR. Julien. |
This was referenced Sep 4, 2020
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
Fix some minor inconsistencies in LAPACK(E)_[cz]gesvdq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carrying over 4d792ec from #409 following private communication from @langou / @julielangou, after that PR got overlooked and partially superseded by #434.
Closes #409.