Skip to content

LAPACKE/include/lapack.h: fix C++ compatibility and prototypes for xGGSVD/xGGSVP#434

Merged
julielangou merged 2 commits into
Reference-LAPACK:masterfrom
martin-frbg:lapacke_lapack_h
Sep 1, 2020
Merged

LAPACKE/include/lapack.h: fix C++ compatibility and prototypes for xGGSVD/xGGSVP#434
julielangou merged 2 commits into
Reference-LAPACK:masterfrom
martin-frbg:lapacke_lapack_h

Conversation

@martin-frbg

Copy link
Copy Markdown
Collaborator

Backports from OpenBLAS :

  1. need to include rather than <complex.h> in a C++ context (this was also created as issue lapacke and its interaction with complex when using C++ #320 here a while ago)
    and need to move the block of LAPACK_COMPLEX_CUSTOM declarations outside the extern "C"
  2. when prototypes for several deprecated LAPACK functions were restored in Restore missing prototypes for deprecated LAPACK functions #367, xGGSVD and xGGSVP erroneously got their LAPACKE prototypes added instead of the LAPACK ones.

@julielangou julielangou merged commit fef5308 into Reference-LAPACK:master Sep 1, 2020
@julielangou

Copy link
Copy Markdown
Contributor

Thank you @martin-frbg , closing #320

@h-vetinari

h-vetinari commented Sep 2, 2020

Copy link
Copy Markdown
Contributor

I'll allow myself to note that 14740d3 is essentially 127f0bf, which has been lying around in #409 for a couple of months.

@martin-frbg

Copy link
Copy Markdown
Collaborator Author

Seems you are right, sorry for not noticing that but I guess our different styles of writing commit messages may be to blame.

@Reference-LAPACK Reference-LAPACK deleted a comment from codecov Bot Sep 2, 2020
h-vetinari added a commit to h-vetinari/lapack that referenced this pull request Sep 4, 2020
h-vetinari added a commit to h-vetinari/lapack that referenced this pull request Sep 4, 2020
… 'const' in signatures

Based on how the surrounding functions in lapack.h are handling the
parameters, particularly the ?ggsv?3-variants of the affected functions
langou added a commit that referenced this pull request Sep 4, 2020
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
…ck_h

LAPACKE/include/lapack.h: fix C++ compatibility and prototypes for xGGSVD/xGGSVP
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
… 'const' in signatures

Based on how the surrounding functions in lapack.h are handling the
parameters, particularly the ?ggsv?3-variants of the affected functions
christoph-conrads pushed a commit to christoph-conrads/lapack that referenced this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants