Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add the possibility to skip configurable rules #1809

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

tatomyr
Copy link
Contributor

@tatomyr tatomyr commented Nov 21, 2024

What/Why/How?

Added the possibility to skip configurable rules using the --skip-rule option.

Reference

Resolves #1806

Testing

Screenshots (optional)

Check yourself

  • Code changed? - Tested with redoc/reference-docs/workflows (internal)
  • All new/updated code is covered with tests
  • New package installed? - Tested in different environments (browser/node)

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@tatomyr tatomyr requested review from a team as code owners November 21, 2024 10:31
Copy link

changeset-bot bot commented Nov 21, 2024

🦋 Changeset detected

Latest commit: 5d073ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@redocly/openapi-core Patch
@redocly/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Command Mean [ms] Min [ms] Max [ms] Relative
redocly lint packages/core/src/benchmark/benches/rebilly.yaml 974.3 ± 11.5 954.3 991.9 1.01 ± 0.02
redocly-next lint packages/core/src/benchmark/benches/rebilly.yaml 967.7 ± 13.7 947.3 990.4 1.00

@@ -13,7 +13,3 @@ output/
*.tgz
redoc-static.html
packages/cli/README.md
/redocly.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove it as it makes it harder to find the current configuration file changes.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 78.78% 5016/6367
🟡 Branches 67.47% 2076/3077
🟡 Functions 73.32% 830/1132
🟡 Lines 79.08% 4734/5986
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / config.ts
68.31% (-1.53% 🔻)
73.02% (-1.78% 🔻)
73.53%
68.1% (-1.71% 🔻)

Test suite run success

812 tests passing in 121 suites.

Report generated by 🧪jest coverage report action from 5d073ec

@Marshevskyy Marshevskyy merged commit f55be3f into main Nov 21, 2024
40 checks passed
@Marshevskyy Marshevskyy deleted the fix/skip-configurable-rules branch November 21, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redocly lint - cannot skip custom rules/assertions
3 participants