fix: enable path parsing to account for root level paths #1638
Conversation
🦋 Changeset detectedLatest commit: 3003f7f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the pull request @LukeHagar , we'll take a look. |
|
@LukeHagar do you mind adding a simple e2e test for the case? |
|
I'd be happy too, I realize this solution would also collide with any API endpoints that are actually |
|
@lornajane @tatomyr I think this is right. I couldn't get any of the tests to run locally due to a warning about an outdated dep messing with the snapshot output |
It's most likely because you're using Node version 21 or higher. If you try version 20 or earlier, it should work locally. |
|
Yup I'm on |
| @@ -130,6 +130,9 @@ export function printExecutionTime(commandName: string, startedAt: number, api: | |||
| } | |||
|
|
|||
| export function pathToFilename(path: string, pathSeparator: string) { | |||
| if (path === '/') { | |||
| return '~root'; | |||
There was a problem hiding this comment.
Does this mean that it will create a file named ~root for the root path?
What/Why/How?
Fixes #1634
Reference
Testing
Screenshots (optional)
Check yourself
Security