Skip to content

Conversation

@outousekai
Copy link
Contributor

@outousekai outousekai commented Dec 17, 2020

[add] added DropIndex method (#94)

The parameters of this method:

  • deleteDocuments if true,add DD option

@codecov
Copy link

codecov bot commented Dec 17, 2020

Codecov Report

Merging #96 (f53f858) into master (3264ad8) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #96      +/-   ##
==========================================
+ Coverage   76.59%   76.76%   +0.17%     
==========================================
  Files          13       13              
  Lines        1081     1089       +8     
==========================================
+ Hits          828      836       +8     
  Misses        197      197              
  Partials       56       56              
Impacted Files Coverage Δ
redisearch/client.go 79.27% <100.00%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3264ad8...f53f858. Read the comment docs.

@filipecosta90 filipecosta90 linked an issue Dec 18, 2020 that may be closed by this pull request
@filipecosta90 filipecosta90 self-requested a review December 18, 2020 13:27
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
24.1% 24.1% Duplication

@filipecosta90
Copy link
Collaborator

@is-a-gamer @shumin1027 LvGTM.
I've added one test and example to ease adoption.
The code duplication warning comes from the example so we're good to go.

@filipecosta90 filipecosta90 merged commit 4f1c7d9 into RediSearch:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I need to drop the index,but not found this func

3 participants