I need to drop the index,but not found this func

[outousekai]

Sometimes I just need to delete a separate index and should not use it client.Drop()

[filipecosta90]

Hi there @is-a-gamer , agree.
Given that for v1.6 and v2.0 we have FT.DROP and FT.DROPINDEX I would take this opportunity to add:

• DropByName( string indexName, bool keepDocs ) - maps to https://oss.redislabs.com/redisearch/Commands/#ftdrop. We can warn that as of v2.0 DropByName and Drop are deprecated.
• DropIndex( string indexName, bool deleteDocs ) - maps to https://oss.redislabs.com/redisearch/Commands/#ftdropindex

wdyt @gkorland @MeirShpilraien ?

---

Apart from it, @is-a-gamer do you want to submit a PR, or do you want us to do it? Happy to review :)

[MeirShpilraien]

@filipecosta90 why not stick to the same name as in the api, i.e, Drop and DropIndex?

[filipecosta90]

@filipecosta90 why not stick to the same name as in the api, i.e, Drop and DropIndex?

Drop() is already taken since the beginning of the client. Given we can't overload we need a different name :)

[outousekai]

Apart from it, @is-a-gamer do you want to submit a PR, or do you want us to do it? Happy to review :)

No

I added a method to the client.go

func (i *Client) DropIndex(deleteDocument bool) (err error) {
	conn := i.pool.Get()
	defer conn.Close()

	if deleteDocument {
		_, err = conn.Do("FT.DROPINDEX", i.name, "DD")
	} else {
		_, err = conn.Do("FT.DROPINDEX", i.name)
	}
	return
}

Although it can work normally in my process, I think you should do it more correctly

[filipecosta90]

@filipecosta90 why not stick to the same name as in the api, i.e, Drop and DropIndex?

Drop() is already taken since the beginning of the client. Given we can't overload we need a different name :)

@MeirShpilraien, bumping this one. I believe we should go with due to the reasons discussed above:

• DropByName( string indexName, bool keepDocs ) - maps to https://oss.redislabs.com/redisearch/Commands/#ftdrop. We can warn that as of v2.0 DropByName and Drop are deprecated.
• DropIndex( string indexName, bool deleteDocs ) - maps to https://oss.redislabs.com/redisearch/Commands/#ftdropindex

[shumin1027]

@filipecosta90
how about

// Deletes the index.
// By default, FT.DROPINDEX does not delete the document hashes associated with the index. Adding the DD option deletes the hashes as well.
func (i *Client) dropIndex(keepdocs bool) error {
	conn := i.pool.Get()
	defer conn.Close()

	var err error = nil
	if keepdocs {
		_, err = conn.Do("FT.DROPINDEX", i.name)
	} else {
		_, err = conn.Do("FT.DROPINDEX", i.name, "DD")
	}
	return err
}

// Deletes the index and deletes the hashes as well
func (i *Client) DropIndex() error {
	return i.dropIndex(false)
}

// Deletes the index but does not delete the document hashes associated with the index
func (i *Client) DropIndexWithKeepdocs() error {
	return i.dropIndex(true)
}

[filipecosta90]

@filipecosta90
how about

// Deletes the index.
// By default, FT.DROPINDEX does not delete the document hashes associated with the index. Adding the DD option deletes the hashes as well.
func (i *Client) dropIndex(keepdocs bool) error {
	conn := i.pool.Get()
	defer conn.Close()

	var err error = nil
	if keepdocs {
		_, err = conn.Do("FT.DROPINDEX", i.name)
	} else {
		_, err = conn.Do("FT.DROPINDEX", i.name, "DD")
	}
	return err
}

// Deletes the index and deletes the hashes as well
func (i *Client) DropIndex() error {
	return i.dropIndex(false)
}

// Deletes the index but does not delete the document hashes associated with the index
func (i *Client) DropIndexWithKeepdocs() error {
	return i.dropIndex(true)
}

@shumin1027 I would use DropIndex( string indexName, bool deleteDocs ) for one reason. Please notice that DD argument maps directly to deleteDocs argument. On your function signature we have the inverse keepdocs which might confuse users.

[filipecosta90]

@is-a-gamer @shumin1027 do you guys want to propose a PR. Will gladly review it :)