Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert sort type change #1870

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Revert sort type change #1870

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4c6a2ea
Revert sort type change
mikerebilly Apr 11, 2024
6effd6c
Remove example
mikerebilly Apr 11, 2024
4d6b665
Merge branch 'main' into revert-sort-type-change
justnero Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions openapi/components/parameters/collectionSort.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@ in: query
description: |-
Sorts and orders the collection of items. To sort in descending
order, prefix with `-`. Multiple fields can be sorted by separating each with `,`.
example: -createdTime,firstName
style: form
explode: false
schema:
type: string
type: array
ashkarpetin marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

@ashkarpetin ashkarpetin Apr 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why collectionExpand described different way, without style/explode

api-definitions/openapi/components/parameters/collectionExpand.yaml

Lines 9 to 10 in 5fbaee8

schema:
type: string

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a fair point. It's actually the same thing and should be defined the same way.

items:
type: string