Revert sort type change #1870
Merged
Revert sort type change #1870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
noon-dawg
approved these changes
Apr 11, 2024
mehicalen
approved these changes
Apr 11, 2024
ashkarpetin
reviewed
Apr 11, 2024
ashkarpetin
approved these changes
Apr 11, 2024
ashkarpetin
reviewed
Apr 11, 2024
| style: form | ||
| explode: false | ||
| schema: | ||
| type: string | ||
| type: array |
There was a problem hiding this comment.
I wonder why collectionExpand described different way, without style/explode
There was a problem hiding this comment.
That's a fair point. It's actually the same thing and should be defined the same way.
justnero
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#1868 turned sort into
type: stringwithstyle: form, the original definition was correct. I kept the description update though.Links
https://swagger.io/specification/#style-values:~:text=200.B%3D150-,form,false,-color%3D
Checklist