feat: Add installer status dialog

[oSumAtrIX]

This PR shows a native dialogue after the installation finishes. It can handle all status flags. Business logic may move.

Todo

• Handle errors such as:
  • Installing regularly while a mount installation is currently active (In this case, uninstall the mount installation)
  • Mount errors such as wrong base APK or no base APK present (In this case, show an appropriate dialog)

Review

• Check if https://github.com/ReVanced/revanced-manager/pull/1473/files#diff-bd497764717bba99312a9c9db9f60eaa4c5d090266194189db6855574572564bR55 is placed in a suitable location
• When uninstallation is necessary, first the uninstallation prompt is shown, then the installation prompt
• All strings are chosen appropriately
• All icons are chosen appropriately
• Showing a SUCCESS status dialog is wanted
• All TODOs in this PR are considered or done
• uiSafe has been used correctly (In some places, it seems it should be used but it seems out of scope for this PR)

Warning

On installation, the install button is not greyed out, and no progress is visible, so it appears as if nothing happened.

[KobeW50]

Suggestion for the "invalid" error description

[KobeW50]

String changes in error dialog

[KobeW50]

Is this also for when you update the Manager?

[CnC-Robert]

Is this also for when you update the Manager?

No it's only for installing patched apps

[Ushie]

ReVanced Manager Updates will also use this, but this PR focuses on patched apps

[oSumAtrIX]

@ Axelen123 Currently, the extra status message is not used, but I don't know which extra status messages exist so that I can implement them. For example, if an existing installation is present, but the patched app mismatches signatures, then the dialogue will say:

This flag is returned from installation, and there is no way to differentiate between an APK being invalid, for example, or a signature mismatch.

Furthermore, when uninstalling, the dialogue may also be shown. But once again, there is no way to differentiate between installations, uninstallations or the status message, so the dialogue may say that the installation has failed while the uninstallation failed.

[oSumAtrIX]

msedge_XcwCJ412Tb.mp4

(The recording is cut off at the end, it shows the success dialogue when installation succeeded)

[Axelen123]

@ Axelen123 Currently, the extra status message is not used, but I don't know which extra status messages exist so that I can implement them. For example, if an existing installation is present, but the patched app mismatches signatures, then the dialogue will say:

This flag is returned from installation, and there is no way to differentiate between an APK being invalid, for example, or a signature mismatch.

Not sure why Android says the app is invalid. Android should give you CONFLICT on signature mismatch. What is the content of the EXTRA_STATUS_MESSAGE here?

Furthermore, when uninstalling, the dialogue may also be shown. But once again, there is no way to differentiate between installations, uninstallations or the status message, so the dialogue may say that the installation has failed while the uninstallation failed.

Isn't it possible to make a separate dialog or enum for uninstalls?

[oSumAtrIX]

Isn't it possible to make a separate dialog or enum for uninstalls?

Yes, but ideally we would have the existing Flags enum have variants of the install and uninstall strings.

[Ushie]

Will root install be handled in this?

[oSumAtrIX]

@Axelen123 I have updated the PR description with up to date information.

[Axelen123]

Code looks good to me. The PR can be merged after dealing with the final comment.

[oSumAtrIX]

Not sure, if caused by this PR but I tried patching YT via the asset produced by a workflow run on this PR, and after clicking on install, it mentioned an installation conflict and blocked installation. Saving the APK file was also disabled. ReVanced Manager Flutter did install the patched app

[Axelen123]

Looks like I missed that. This PR does introduce a check, but it does not account for patches that change the package name.

[oSumAtrIX]

The issue stems from the fact that the dialog uses the input apk, but since we install the output apk, the output should be used