Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Flutter/Compose): Improve the message of incompatible installation #2140

Closed
3 tasks done
kitadai31 opened this issue Aug 15, 2024 · 4 comments · Fixed by #2149
Closed
3 tasks done

feat(Flutter/Compose): Improve the message of incompatible installation #2140

kitadai31 opened this issue Aug 15, 2024 · 4 comments · Fixed by #2149
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@kitadai31
Copy link
Contributor

kitadai31 commented Aug 15, 2024

Feature description

It says "Contact the developer of the app and ask for support."
However, in most cases, this is caused by the user has used the wrong APK.

I think this message can be like "Check if you are using a correct APK for your device and try again."
Or just only "The app is incompatible with this device." would be fine.

installation_incompatible

This is related to compose manager for #1473

Motivation

In most cases, this is caused by the user has used the wrong architecture APK.
In this case, asking developer for support is wrong solution.
Therefore, this one sentence is no point.
I think the dialog should only contain instructions that actually lead to a solution.

(I know this may also happen when the device hardware does not meet <uses-feature>, but this is a rare case.)

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@kitadai31 kitadai31 added the Feature request Requesting a new feature that's not implemented yet label Aug 15, 2024
@KobeW50
Copy link
Contributor

KobeW50 commented Aug 27, 2024

What a lovely world :)
I cannot be happier

image

(Made a new GH account to PR for this, since my main account has a fork for inotia00's rvx-manager, which prevents me from creating a fork of this repo)

Here is the changed file if it is useful: https://github.com/KobeW5050/revanced-manager/blob/dev/assets/i18n/strings.i18n.json

@Ushie
Copy link
Member

Ushie commented Aug 27, 2024

There's no restriction to how many repos you can fork, you just had to rename the repo when forking

@KobeW50
Copy link
Contributor

KobeW50 commented Aug 27, 2024

inotia00's rvx manager repository is a fork of this repository, so GitHub considers my fork of inotia00's repository as a fork of this repository. Also, my fork of inotia00's repo has a unique name.

Here is a screenshot from the fork creation page.
Screenshot_20240827_015507_Firefox

@kitadai31
Copy link
Contributor Author

@KobeW50

(Made a new GH account to PR for this, since my main account has a fork for inotia00's rvx-manager, which prevents me from creating a fork of this repo)

You don't have to that.
Both your RVX Manager fork and inotia00's RVX Manager belong to the "fork network" of ReVanced/revanced-manager.
So you can open a PR to ReVanced/revanced-manager directly from a fork of another fork.
(That's why GitHub restricts multiple creation of fork.)
Checkout the dev branch of ReVanced/revanced-manager, then create a new branch from the official dev branch, add changes, push the new branch to your fork, and open a PR.

Look this, I opened a PR to compose-dev branch from ReVanced Manager for Android 5-7 repository.
#2147
https://github.com/kitadai31/revanced-manager-android5-7/tree/fix/keep-screen-on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants