feat: Request the update ownership enforcement #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
requested changes
May 22, 2025
src/commonMain/kotlin/app/revanced/library/installation/installer/AdbInstaller.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/app/revanced/library/installation/installer/AdbInstaller.kt
Outdated
Show resolved
Hide resolved
src/commonMain/kotlin/app/revanced/library/installation/installer/AdbInstaller.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
requested changes
May 22, 2025
oSumAtrIX
changed the title
oSumAtrIX
changed the title
brosssh
commented
May 22, 2025
src/androidMain/AndroidManifest.xml
Outdated
There was a problem hiding this comment.
Is adding the manifest like this correct?
There was a problem hiding this comment.
I don't think that libraries can have a manifest. Basically the target apps manifest needs to add this, you can (maybe) remove the file
There was a problem hiding this comment.
Should be ok now, I didn't see that for other permissions the lint debug error was just suppressed. I did the same.
However the new JADB version is still not released, can you manually do it?
oSumAtrIX
approved these changes
May 27, 2025
|
Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution. |
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
# [3.2.0-dev.1](v3.1.1-dev.1...v3.2.0-dev.1) (2025-05-27) ### Features * Request the update ownership enforcement ([#71](#71)) ([be0f6bf](be0f6bf))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ReVanced/jadb#1.