feat: Add option to update app ownership #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `getSdkVersion` to `JadbDevice` - Made public `InstallOption` init (so custom string options can be passed, such as "--update-ownership")
|
Not sure if pom.xml is automatically bumped or it's manual here. |
oSumAtrIX
requested changes
May 22, 2025
|
Pom needs to be bumped manually. You can set it to 1.2.1.1 |
|
This PR should be upstreamed, open it in upstream as well once its merged here. |
|
Why? Making the constructor public adds versability to this library, else every time we want to add a new flag we have to add it like this..
|
|
Because the PR is supposed to add support for add ownership not change the initial design of the class. I don't know why it was private, but there quite surely is a reason this PR is not supposed to address. |
oSumAtrIX
reviewed
May 22, 2025
oSumAtrIX
approved these changes
May 26, 2025
oSumAtrIX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSdkVersiontoJadbDeviceInstallOptioninit (so custom string options can be passed, such as "--update-ownership")