Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Super Simplex noise #168

Merged
merged 14 commits into from
Jun 3, 2017
Merged

Conversation

mystise
Copy link
Contributor

@mystise mystise commented May 31, 2017

Implemented in 2D and 3D, no 4D implementation was available to port, so it was left out.

The maximum values were determined in Mathematica, and as such should be as exact as possible, so the output range should be [-1,1]. The Mathematica script used to produce the maximum values is included both in the comments in the new example, and also in the find_maximum_super_simplex.nb file.

The example produces the necessary lookup tables, and was originally going to produce the maximum value before the computation was moved to Mathematica, since the Newton's method code I wrote (and then deleted) was producing incorrect values which were provably not maximum.

Closes #161

@Razaekel
Copy link
Owner

Awesome! Thanks for adding this! That must have taken a while to figure out the conversion from the original java implementation, and dealing with the issues that came up.

My only request at this point would be that the find_maximum_super_simplex.nb file be removed. I know that I personally don't have a license for Mathematica, and without that, it would be hard to prevent the code from rotting over time. Ideally, the code would be implemented in Rust, which would make it easier to support, but I understand if you don't want to deal with translating that.

@mystise
Copy link
Contributor Author

mystise commented May 31, 2017

Works fine for me. If there were an open source alternative to Mathematica I'd also be happy to convert it at a later date. I tried to convert it to Rust, but for some reason it was returning provably wrong results. I can try again later, but for now I'll just remove the Mathematica file from the repo.

@mystise
Copy link
Contributor Author

mystise commented May 31, 2017

Request re-evaluation

@Razaekel Razaekel merged commit 051f8f7 into Razaekel:master Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants