feat!: Improve accessibility of the grid field. #2488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
rachel-fenichel
approved these changes
Feb 13, 2025
cpcallen
pushed a commit
to cpcallen/blockly-samples
that referenced
this pull request
May 7, 2025
…n#2488) * feat!: Improve accessibility of the grid field. * chore: Fix lint problems. * chore: Clarify comments. * refactor: Limit imports. * refactor: Include `field` in CSS class names. * refactor: Move grid item population into its own function. * refactor: Use null instead of undefined for selection callback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2481
Proposed Changes
This PR updates the grid field to improve its accessibility. Specifically:
grid, made up of rows and cells with the appropriate roles.Breaking Changes
Since this field no longer uses menus as its backing representation, the CSS class structure has changed dramatically. Broadly speaking,
.blocklyFieldGridtargets the grid itself, and.blocklyFieldGridItemtargets each individual item. For details, refer to the CSS registered at the end of index.ts.