(User testing only) Keyboard accessibility for the imagedropdown and images fields #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying review-pxt with
|
| Latest commit: |
3a046e7
|
| Status: | ⚡️ Build in progress... |
microbit-robert
changed the title
microbit-robert
force-pushed
the
image-dropdown
branch
from
a172904 to
f0991ff
Compare
microbit-robert
commented
Feb 21, 2025
| button.setAttribute('aria-selected', 'true'); | ||
| this.activeDescendantIndex = i; | ||
| contentDiv.setAttribute('aria-activedescendant', button.id); | ||
| button.setAttribute('class', `blocklyDropDownButton ${e ? "blocklyDropDownButtonHover" : "blocklyDropDownButtonFocus"}`); |
Collaborator
Author
There was a problem hiding this comment.
This is setting a keyboard focus indicator on the currently selected icon when the dropdown is opened by anything other than a mouse event. Ideally, we'd only do this when we knew it was a keyboard event. The same code is in the field_images.ts file.
Deploying review-pxt with
|
| Latest commit: |
3a046e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ec3f6a5b.review-pxt.pages.dev |
| Branch Preview URL: | https://image-dropdown.review-pxt.pages.dev |
Deploying review-pxt with
|
| Latest commit: |
3a046e7
|
| Status: | ⚡️ Build in progress... |
Deploying review-pxt with
|
| Latest commit: |
3a046e7
|
| Status: | 🚫 Build failed. |
microbit-matt-hillsdon
changed the base branch from
blockly-keyboard-experiment
to
march-ut
microbit-matt-hillsdon
changed the title
Deploying review-pxt with
|
| Latest commit: |
7781286
|
| Status: | ⚡️ Build in progress... |
microbit-robert
force-pushed
the
image-dropdown
branch
from
3a046e7 to
7781286
Compare
Owner
|
Not deleting the branch as we may resurrect this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We intend to merge this into a user testing branch only. The longer term plan is to move these fields over from extending Blockly's dropdown field to extending Blockly's grid field after recent improvements to the keyboard navigation for that field.
We are still waiting for the grid field to be more open to the types of items it can take, see RaspberryPiFoundation/blockly-samples#2482.