Enable flake8 code E501 #8680
Merged
Enable flake8 code E501 #8680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a pull request 🚀 @rctatman will take a look at it as soon as possible ✨ |
iurisevero
force-pushed
the
8490-Enable-flake8-code-E501
branch
from
4e9afa1
to
2c34e80
Compare
wochinge
reviewed
May 17, 2021
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
|
@wochinge I resolved all conversations, but every time I merge with main, it can break the CI in code quality. I'll fix it this last time and stop updating this branch, ok? |
wochinge
reviewed
May 26, 2021
tests/shared/core/test_domain.py
Outdated
| @@ -75,16 +75,16 @@ async def test_create_train_data_no_history(domain: Domain, stories_path: Text): | |||
|
|
|||
| assert hashed == [ | |||
There was a problem hiding this comment.
the comments here and in test_telemetry are pretty extensive. What about ignoring the entire files for now?
There was a problem hiding this comment.
It's better to add a flake8: noqa or re-add the per-file-ignore at the setup?
Co-authored-by: Tobias Wochinger <[email protected]>
Co-authored-by: Tobias Wochinger <[email protected]>
wochinge
reviewed
Jun 3, 2021
|
LOL surprisingly there were no failed checks! @wochinge it's all yours xD |
wochinge
approved these changes
Jun 3, 2021
|
Thanks for this change! @iurisevero Having this check automated will greatly help to maintain consistency in the codebase in the future 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #8490
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)