Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flake8 code E501 #8490

Closed
2 tasks
wochinge opened this issue Apr 19, 2021 · 2 comments · Fixed by #8680
Closed
2 tasks

Enable flake8 code E501 #8490

wochinge opened this issue Apr 19, 2021 · 2 comments · Fixed by #8680
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

Description of Problem:
We currently ignore Flake E501 warnings for too long lines.

Overview of the Solution:

  • exclude E501 from ignore test
  • fix too long lines issues from make lint

Definition of Done:

  • E501 is no longer ignored
  • the CI passes
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Apr 19, 2021
@wochinge wochinge mentioned this issue Apr 19, 2021
Merged
4 tasks
@iurisevero
Copy link
Contributor

Hey there. I would like to work on this issue if it's available :)

@iurisevero iurisevero mentioned this issue May 12, 2021
Merged
4 tasks
@wochinge
Copy link
Contributor Author

sounds good! Thanks for your support @iurisevero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable flake8 code E501 FGA-GCES/rasa
2 participants
@wochinge @iurisevero