8461 non expressive variable name #8504
Conversation
|
Thanks for submitting a pull request 🚀 @ArjaanBuijk will take a look at it as soon as possible ✨ |
rasa/utils/tensorflow/transformer.py
Outdated
| @@ -563,8 +563,8 @@ def __init__( | |||
| self._layer_norm = tf.keras.layers.LayerNormalization(epsilon=1e-6) | |||
|
|
|||
| def _get_angles(self) -> np.ndarray: | |||
| i = np.arange(self.units)[np.newaxis, :] | |||
| return 1 / np.power(10000, (2 * (i // 2)) / np.float32(self.units)) | |||
| array_2D = np.arange(self.units)[np.newaxis, :] | |||
There was a problem hiding this comment.
please use all lowercase: array_2d
rasa/utils/tensorflow/transformer.py
Outdated
| i = np.arange(self.units)[np.newaxis, :] | ||
| return 1 / np.power(10000, (2 * (i // 2)) / np.float32(self.units)) | ||
| array_2D = np.arange(self.units)[np.newaxis, :] | ||
| return 1 / np.power(10000, (2 * (array_2D // 2)) / np.float32(self.units)) |
There was a problem hiding this comment.
please use all lowercase: array_2d
…m/FGA-GCES/rasa into 8461-non-expressive-variable-name
|
@joaoCeilandia , |
|
Has no conflicts with the base branch now. I don't know if i can make my branch writeable for you because it is from a class in my college. @ArjaanBuijk |
|
@joaoCeilandia , sorry it has to be done this way, but if you are not able to make your branch writeable for me, you will have to update it manually again. Things are added quickly, and your PR is in the queue to be merged in, but it needs to be squeezed in there. |
|
@joaoCeilandia , |
Proposed changes:
-fix #8461
Status (please check what you already did):
black(please check Readme for instructions)