Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non expressive variable name on transformer.py #8461

Closed
joaoCeilandia opened this issue Apr 13, 2021 · 3 comments · Fixed by #8504
Closed

Non expressive variable name on transformer.py #8461

joaoCeilandia opened this issue Apr 13, 2021 · 3 comments · Fixed by #8504
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@joaoCeilandia
Copy link
Contributor

Description of Problem:
Issue: On file ...\utils\tensorflow\transformer.py in the line 566 has a variable with a non expressive name i.

Overview of the Solution:
Change the name from i to something more expressive.

@joaoCeilandia joaoCeilandia added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Apr 13, 2021
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @melindaloubser1 will get back to you about it soon! ✨

@indam23
Copy link
Contributor

indam23 commented Apr 14, 2021

def _get_angles(self) -> np.ndarray:
i = np.arange(self.units)[np.newaxis, :]
return 1 / np.power(10000, (2 * (i // 2)) / np.float32(self.units))

What would you change it to?

@indam23
Copy link
Contributor

indam23 commented Apr 14, 2021

Since you already opened a PR to fix #8453, you could add a fix there for this too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants