Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8463 non expressive variable name on domain #8465

Conversation

joaoCeilandia
Copy link
Contributor

@joaoCeilandia joaoCeilandia commented Apr 14, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨

@sara-tagger sara-tagger requested a review from degiz April 14, 2021 06:00
@TyDunn
Copy link
Contributor

TyDunn commented May 5, 2021

@melindaloubser1 I believe this was fixed in #8528, correct?

@indam23
Copy link
Contributor

indam23 commented May 5, 2021

Yes, correct

@indam23 indam23 closed this May 5, 2021
@ErickGiffoni ErickGiffoni deleted the 8463-non-expressive-variable-name-on-domain branch August 5, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non expressive variable name on domain.py
4 participants