Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non expressive variable name on domain.py #8463

Closed
joaoCeilandia opened this issue Apr 14, 2021 · 1 comment · Fixed by #8528
Closed

Non expressive variable name on domain.py #8463

joaoCeilandia opened this issue Apr 14, 2021 · 1 comment · Fixed by #8528
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@joaoCeilandia
Copy link
Contributor

Description of Problem:
Issue: On file ...\shared\core\domain.py in the line 250 and 252 has two variables with non expressive names a and b.

Overview of the Solution:
Change the name from a and b to something more expressive.
@joaoCeilandia joaoCeilandia added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels Apr 14, 2021
@joaoCeilandia joaoCeilandia mentioned this issue Apr 14, 2021
Closed
4 tasks
@sara-tagger
Copy link
Collaborator

Thanks for submitting this feature request 🚀 @JustinaPetr will get back to you about it soon! ✨

@indam23 indam23 mentioned this issue Apr 29, 2021
Merged
@TyDunn TyDunn added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR labels May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring variables FGA-GCES/rasa
8463 non expressive variable name on domain FGA-GCES/rasa
3 participants
@TyDunn @joaoCeilandia @sara-tagger