Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minimum compatible version to --version command #8184

Merged
merged 10 commits into from
Mar 12, 2021
Merged

Add minimum compatible version to --version command #8184

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad084d5
Add minimum compatible version to --version command
joaoCeilandia Mar 11, 2021
d8adf8c
Create 7477.enhancement
joaoCeilandia Mar 11, 2021
beade7f
Rename 7477.enhancement to 7477.enhancement.md
joaoCeilandia Mar 11, 2021
0b9348a
Set spacing to line up versions
joaoCeilandia Mar 12, 2021
a0a4cb8
reformat files using black
joaoCeilandia Mar 12, 2021
e2704ce
Add docstring to main funtion
joaoCeilandia Mar 12, 2021
886df46
Add dot to docstring in main
joaoCeilandia Mar 12, 2021
23ab91a
Change docstring to imperative
joaoCeilandia Mar 12, 2021
38a9675
Remove blank line after docstring in main
joaoCeilandia Mar 12, 2021
6da2eef
Merge branch 'main' into 7477-expose-minimum-compatible-version
joaoCeilandia Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/7477.enhancement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add minimum compatible version to --version command
16 changes: 9 additions & 7 deletions rasa/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import sys

from rasa_sdk import __version__ as rasa_sdk_version
from rasa.constants import MINIMUM_COMPATIBLE_VERSION

import rasa.telemetry
import rasa.utils.io
Expand Down Expand Up @@ -82,16 +83,17 @@ def print_version() -> None:
except ModuleNotFoundError:
rasa_x_info = None

print(f"Rasa Version : {version.__version__}")
print(f"Rasa SDK Version : {rasa_sdk_version}")
print(f"Rasa X Version : {rasa_x_info}")
print(f"Python Version : {platform.python_version()}")
print(f"Operating System : {platform.platform()}")
print(f"Python Path : {sys.executable}")
print(f"Rasa Version : {version.__version__}")
print(f"Minimum Compatible Version: {MINIMUM_COMPATIBLE_VERSION}")
print(f"Rasa SDK Version : {rasa_sdk_version}")
print(f"Rasa X Version : {rasa_x_info}")
print(f"Python Version : {platform.python_version()}")
print(f"Operating System : {platform.platform()}")
print(f"Python Path : {sys.executable}")


def main() -> None:
# Running as standalone python application
"""Running as standalone python application"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Running as standalone python application"""
"""Run as standalone python application"""

By convention we use the imperative


parse_last_positional_argument_as_model_path()
arg_parser = create_argument_parser()
Expand Down