Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum compatible version to --version command #8184

Merged
merged 10 commits into from
Mar 12, 2021

Conversation

joaoCeilandia
Copy link
Contributor

@joaoCeilandia joaoCeilandia commented Mar 11, 2021

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @melindaloubser1 will take a look at it as soon as possible ✨

Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!
Minor thing: Could you set the spacing so that the versions all line up like before? Right now it looks like this:

Rasa Version     : 2.4.0
Minimum Compatible Version     : 2.2.0a1
Rasa SDK Version : 2.4.0
Rasa X Version   : None
Python Version   : 3.7.4

something like this:

Rasa Version      :         2.4.0
Minimum Compatible Version: 2.2.0a1
Rasa SDK Version  :         2.4.0
Rasa X Version    :         None
Python Version    :         3.7.4

@joaoCeilandia
Copy link
Contributor Author

@melindaloubser1 done!

Copy link
Contributor

@indam23 indam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@indam23 indam23 enabled auto-merge March 12, 2021 21:24
@joaoCeilandia
Copy link
Contributor Author

image
@melindaloubser1 this check is failling and i don't know why. Could you give me a hint?

@indam23
Copy link
Contributor

indam23 commented Mar 12, 2021

It says

rasa/__main__.py:95:1: D103 Missing docstring in public function

This is because of a check introduced some months ago that requires docstrings be added to any new or changed functions.
Not sure why it picks up main() as changed - probably because of the surrounding lines - but you can use the existing comment on line 96 as the docstring e.g.

def main() -> None:
     """Run as standalone python application"""

rasa/__main__.py Outdated
@@ -93,7 +93,7 @@ def print_version() -> None:


def main() -> None:
# Running as standalone python application
"""Running as standalone python application"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""Running as standalone python application"""
"""Run as standalone python application"""

By convention we use the imperative

@indam23 indam23 merged commit 2ed20f6 into RasaHQ:main Mar 12, 2021
@ErickGiffoni ErickGiffoni deleted the 7477-expose-minimum-compatible-version branch August 5, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose MINIMUM_COMPATIBLE_VERSION in rasa version's output
3 participants