Refactor set states from prototyper.jsx #8169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Teodosio <[email protected]> Co-authored-by: ericoBandeira <[email protected]>
|
Thanks for submitting a pull request 🚀 @degiz will take a look at it as soon as possible ✨ |
|
cc @alwx I don't think I have enough knowledge of the topic 😬 |
|
Hey @santosm46! Thanks for your contribution. I would only be able to take a proper look and test it next week (probably on Monday/Tuesday). |
|
While I find your changes nice, I would like to skip them for now because Playground requires more deep analysis and work — there are many things there that need to be refactored, and this sort of refactoring is more like a code style change. I will save it for later and will come back to it once we decide what to do next with the Playground component. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
prototyper.jsxprototyper.jsx#8113Status (please check what you already did):
black(please check Readme for instructions)