Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prototyper.jsx #8113

Closed
alwx opened this issue Mar 4, 2021 · 1 comment
Closed

Refactor prototyper.jsx #8113

alwx opened this issue Mar 4, 2021 · 1 comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@alwx
Copy link
Contributor

alwx commented Mar 4, 2021 •
edited by rasabot-exalate
Loading

Description of Problem: A file named docs/themes/theme-custom/theme/Prototyper/prototyper.jsx was written a while ago, and should definitely be refactored.

  1. the name of this component has changed since we introduced it, and it's now called Playground — this change should be reflected
  2. we can reduce dependencies (see @gausie's idea here: Add all missing dependencies to Rasa Playground onLiveCodeChange callback function  #8109 (review))
  3. we can also rewrite it in TypeScript to make more type safe
  4. the Rasa Playground frontend component is not yet merged (

    😅
    ): https://github.com/RasaHQ/rasa-x/pull/3215
@alwx alwx added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 4, 2021
@ericoBandeira
Copy link
Contributor

ericoBandeira commented Mar 4, 2021 •
edited by rasabot-exalate
Loading

Exalate commented:

ericoBandeira commented:

Hi, I'm interested in this problem, can I work on this issue?

@santosm46 santosm46 mentioned this issue Mar 11, 2021
Closed
4 tasks
@ericoBandeira ericoBandeira mentioned this issue Mar 11, 2021
Closed
@TyDunn TyDunn added the type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. label Apr 16, 2021
@rasabot-exalate rasabot-exalate added area:rasa-oss and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 15, 2022 — with Exalate Issue Sync
@m-vdb m-vdb added type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. area:rasa-oss 🎡 Anything related to the open source Rasa framework and removed area:rasa-oss labels Mar 16, 2022
@rasabot rasabot added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement labels Mar 16, 2022
@rasabot-exalate rasabot-exalate added area:rasa-oss type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR and removed type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss labels Mar 17, 2022 — with Exalate Issue Sync
@rasabot-exalate rasabot-exalate added area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs_:book: type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. and removed type:docs labels Mar 17, 2022 — with Exalate Issue Sync
@m-vdb m-vdb closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor set states from prototyper.jsx FGA-GCES/rasa
6 participants
@alwx @m-vdb @TyDunn @ericoBandeira @rasabot @rasabot-exalate