Add split_entities_config to TEDPolicy
#7716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghostvv
reviewed
Jan 13, 2021
…se it doesn't make sense
koernerfelicia
added
the
tools:clear-poetry-cache-unit-tests
|
@tttthomasssss and @Ghostvv, I applied the suggestions. One thing I'm not so sure whether ResponseSelector should have a default value for |
|
ResponseSelector doesn't extract entities, so I'd say that it shouldn't have it. @tttthomasssss could you please review the PR, since the original config is yours |
|
@koernerfelicia great work 🚀 ! I've left a few comments. |
tttthomasssss
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Closes #7707
Status (please check what you already did):
black(please check Readme for instructions)