Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add split_entities_config to TEDPolicy for e2e #7707

Closed
koernerfelicia opened this issue Jan 11, 2021 · 0 comments · Fixed by #7716
Closed

Add split_entities_config to TEDPolicy for e2e #7707

koernerfelicia opened this issue Jan 11, 2021 · 0 comments · Fixed by #7716
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@koernerfelicia
Copy link
Contributor

Rasa version:
2.2.2
Python version:
3.7.2
Operating system (windows, osx, ...):
OSX

Issue:

TEDPolicy needs a split_entities_config value, to mirror CRFEntityExtractor and DIET

When we call convert_predictions_into_entities, the value of split_entities_config is None, which is only a problem if we then call EntityExtractor._check_is_single_entity. I think this is somewhat rare, which is why the bug went unnoticed so far.

TEDPolicy should have its own value for this, with the same default as DIET, and this parameter should be configurable in the same way.

@koernerfelicia koernerfelicia added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Jan 11, 2021
@koernerfelicia koernerfelicia self-assigned this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant