Amend response schema to support missing top-level keys #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pheel
requested review from
a team and
federicotdn
and removed request for
a team
|
Thanks for submitting a pull request 🚀 @amn41 will take a look at it as soon as possible ✨ |
tmbo
approved these changes
Dec 1, 2020
eanile
added a commit
to UTkzhang/rasa
that referenced
this pull request
Dec 2, 2020
* backport fix * backport pika fix * pika fix backport * fix tests * test fixes * remove logger statement * Updated version of PikaMessageProcessor from the source branch * Small bugfix * changelog * prepared release of version 1.10.16 * Update CHANGELOG.rst Co-authored-by: Ella Rohm-Ensing <[email protected]> * add robots.txt and redirection headers * bump rasabaster version * Fix Pika multiprocessing for 1.10.x * Reformatting * Changelog entry * Updated tests * is_ready method is back * uninstall cached pydocstyle * also uninstall pydocstyle * uninstall in poetry env * Removing f-string * NoReturn -> None * prepared release of version 1.10.17 * Fix incorrect attribute for key prefix in RedisTrackerStore Fix RasaHQ#7306 * Add changelog entry * Remove the set-env command - 1.10.x (RasaHQ#7367) * Fix DynamoDB TrackerStore (RasaHQ#7340) * attempting to fix dynamo * fixed * fixed import * applied some more fixes * added deprecation warning for DynamoDB tracker store attribute * added changelog description for PR 7340 * fix formatting Co-authored-by: Tom Bocklisch <[email protected]> * prepared release of version 1.10.18 (RasaHQ#7381) * Update docstrings * Update CHANGELOG.mdx * line length fix * Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#6793) * Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#3998) Co-authored-by: Henrike100 <[email protected]> * Change the way to show the file name * files formatted with black * add changelog * Update test core * Formatted with black * Update print Co-authored-by: mbslet <[email protected]> * Amend response schema to support missing top-level keys (RasaHQ#7232) * amend response schema to support missing top level keys * changelog entry * download mitie from github instead of s3 (RasaHQ#7434) Co-authored-by: melindaloubser1 <[email protected]> Co-authored-by: alwx <[email protected]> Co-authored-by: Roberto <[email protected]> Co-authored-by: Melinda Loubser <[email protected]> Co-authored-by: Ella Rohm-Ensing <[email protected]> Co-authored-by: m-vdb <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]> Co-authored-by: Duc-Minh Phan <[email protected]> Co-authored-by: Federico Tedin <[email protected]> Co-authored-by: Tomasz Czekajlo <[email protected]> Co-authored-by: Tom Herold <[email protected]> Co-authored-by: Tom Bocklisch <[email protected]> Co-authored-by: Henrique Martins <[email protected]> Co-authored-by: mbslet <[email protected]> Co-authored-by: pheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Add support for the top-level response keys
quick_replies,attachmentandelementsrefered to inrasa.core.channels.OutputChannel.send_reponse, as well asmetadata.Status (please check what you already did):
black(please check Readme for instructions)