Add print to confirm that the failed_test_stories.yml has been saved #6793

Henrike100 · 2020-09-25T02:49:42Z

Proposed changes:

Added a message at the end of rasa test core, showing that the failed stories were saved in results/failed_test_stories.yml, resolving issue Print out "Failed stories written to results/failed_stories.md" at the end of running rasa test core #3998
close Print out "Failed stories written to results/failed_stories.md" at the end of running rasa test core #3998

Default path (results)

User specified path

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

…asaHQ#3998) Co-authored-by: Henrike100 <[email protected]>

CLAassistant · 2020-09-25T02:49:47Z

All committers have signed the CLA.

sara-tagger · 2020-09-25T06:00:20Z

Thanks for submitting a pull request 🚀 @erohmensing will take a look at it as soon as possible ✨

erohmensing

Thank you for the contribution! Works great. I provided some suggestions based on our internal engineering guidelines.

erohmensing · 2020-09-25T13:21:38Z

rasa/cli/test.py

@@ -17,6 +17,8 @@
 )
 import rasa.shared.utils.validation as validation_utils
 import rasa.cli.utils
+from rasa.shared.utils.cli import print_info


Suggested change

from rasa.shared.utils.cli import print_info

import rasa.shared.utils.cli

We don't import methods directly. Instead we import the module they came from and call them explicitly.

And move to line 9, after the other import rasa statements :)

erohmensing · 2020-09-25T13:22:13Z

rasa/cli/test.py

@@ -101,6 +103,8 @@ def run_core_test(args: argparse.Namespace) -> None:
    else:
        test_core_models(args.model, stories, output)

+    print_info("Failed stories written to {}/{}".format(output, FAILED_STORIES_FILE))


Suggested change

print_info("Failed stories written to {}/{}".format(output, FAILED_STORIES_FILE))

rasa.shared.utils.cli.print_info(f"Failed stories written to '{output}/{FAILED_STORIES_FILE}'")

Henrike100 · 2020-09-25T16:32:12Z

@erohmensing thank you for reviewing the PR. I made the suggested changes. When you can, review the PR again, please.

tmbo · 2020-10-27T09:32:36Z

rasa/cli/test.py

@@ -109,6 +110,10 @@ def run_core_test(args: argparse.Namespace) -> None:
    else:
        test_core_models(args.model, stories, output)

+    rasa.shared.utils.cli.print_info(
+        f"Failed stories written to '{output}/{FAILED_STORIES_FILE}'"


Suggested change

f"Failed stories written to '{output}/{FAILED_STORIES_FILE}'"

f"Failed stories written to '{os.path.join(output, FAILED_STORIES_FILE)}'"

(otherwise, this will create wrong paths on windows)

tmbo

thanks a lot for this improvement 🚀 (and sorry for the delay in approving it)

* backport fix * backport pika fix * pika fix backport * fix tests * test fixes * remove logger statement * Updated version of PikaMessageProcessor from the source branch * Small bugfix * changelog * prepared release of version 1.10.16 * Update CHANGELOG.rst Co-authored-by: Ella Rohm-Ensing <[email protected]> * add robots.txt and redirection headers * bump rasabaster version * Fix Pika multiprocessing for 1.10.x * Reformatting * Changelog entry * Updated tests * is_ready method is back * uninstall cached pydocstyle * also uninstall pydocstyle * uninstall in poetry env * Removing f-string * NoReturn -> None * prepared release of version 1.10.17 * Fix incorrect attribute for key prefix in RedisTrackerStore Fix RasaHQ#7306 * Add changelog entry * Remove the set-env command - 1.10.x (RasaHQ#7367) * Fix DynamoDB TrackerStore (RasaHQ#7340) * attempting to fix dynamo * fixed * fixed import * applied some more fixes * added deprecation warning for DynamoDB tracker store attribute * added changelog description for PR 7340 * fix formatting Co-authored-by: Tom Bocklisch <[email protected]> * prepared release of version 1.10.18 (RasaHQ#7381) * Update docstrings * Update CHANGELOG.mdx * line length fix * Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#6793) * Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#3998) Co-authored-by: Henrike100 <[email protected]> * Change the way to show the file name * files formatted with black * add changelog * Update test core * Formatted with black * Update print Co-authored-by: mbslet <[email protected]> * Amend response schema to support missing top-level keys (RasaHQ#7232) * amend response schema to support missing top level keys * changelog entry * download mitie from github instead of s3 (RasaHQ#7434) Co-authored-by: melindaloubser1 <[email protected]> Co-authored-by: alwx <[email protected]> Co-authored-by: Roberto <[email protected]> Co-authored-by: Melinda Loubser <[email protected]> Co-authored-by: Ella Rohm-Ensing <[email protected]> Co-authored-by: m-vdb <[email protected]> Co-authored-by: Tobias Wochinger <[email protected]> Co-authored-by: Duc-Minh Phan <[email protected]> Co-authored-by: Federico Tedin <[email protected]> Co-authored-by: Tomasz Czekajlo <[email protected]> Co-authored-by: Tom Herold <[email protected]> Co-authored-by: Tom Bocklisch <[email protected]> Co-authored-by: Henrique Martins <[email protected]> Co-authored-by: mbslet <[email protected]> Co-authored-by: pheel <[email protected]>

mbslet and others added 4 commits September 19, 2020 21:38

Add print to confirm that the failed_test_stories.yml has been saved (R…

eb1f65b

…asaHQ#3998) Co-authored-by: Henrike100 <[email protected]>

Change the way to show the file name

1662fa2

files formatted with black

6059618

add changelog

720cd48

Merge branch 'master' into failed-storie-message

b7292ad

sara-tagger requested a review from erohmensing September 25, 2020 06:00

erohmensing suggested changes Sep 25, 2020

View reviewed changes

Henrike100 added 3 commits September 25, 2020 11:32

Update test core

f14f3c0

Merge branch 'master' into failed-storie-message

d850770

Formatted with black

2a3ee87

Henrike100 requested a review from erohmensing September 25, 2020 17:15

Henrike100 added 3 commits October 6, 2020 17:04

Merge branch 'master' into failed-storie-message

a0a21a2

Merge branch 'master' into failed-storie-message

580c344

Merge branch 'master' into failed-storie-message

faf0488

tmbo reviewed Oct 27, 2020

View reviewed changes

Henrike100 added 3 commits October 28, 2020 19:18

Merge branch 'master' into failed-storie-message

3bea4ce

Update print

d00cb9d

Merge branch 'master' into failed-storie-message

0804341

tmbo approved these changes Dec 1, 2020

View reviewed changes

tmbo merged commit ed509eb into RasaHQ:master Dec 1, 2020

iurisevero deleted the failed-storie-message branch February 21, 2021 03:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add print to confirm that the failed_test_stories.yml has been saved #6793

Add print to confirm that the failed_test_stories.yml has been saved #6793

Henrike100 commented Sep 25, 2020 •

edited by erohmensing

Loading

CLAassistant commented Sep 25, 2020 •

edited

Loading

sara-tagger commented Sep 25, 2020

erohmensing left a comment

erohmensing Sep 25, 2020

erohmensing Sep 25, 2020

erohmensing Sep 25, 2020 •

edited

Loading

Henrike100 commented Sep 25, 2020

tmbo Oct 27, 2020

tmbo left a comment

	from rasa.shared.utils.cli import print_info
	import rasa.shared.utils.cli

	print_info("Failed stories written to {}/{}".format(output, FAILED_STORIES_FILE))
	rasa.shared.utils.cli.print_info(f"Failed stories written to '{output}/{FAILED_STORIES_FILE}'")

	f"Failed stories written to '{output}/{FAILED_STORIES_FILE}'"
	f"Failed stories written to '{os.path.join(output, FAILED_STORIES_FILE)}'"

Add print to confirm that the failed_test_stories.yml has been saved #6793

Add print to confirm that the failed_test_stories.yml has been saved #6793

Conversation

Henrike100 commented Sep 25, 2020 • edited by erohmensing Loading

CLAassistant commented Sep 25, 2020 • edited Loading

sara-tagger commented Sep 25, 2020

erohmensing left a comment

Choose a reason for hiding this comment

erohmensing Sep 25, 2020

Choose a reason for hiding this comment

erohmensing Sep 25, 2020

Choose a reason for hiding this comment

erohmensing Sep 25, 2020 • edited Loading

Choose a reason for hiding this comment

Henrike100 commented Sep 25, 2020

tmbo Oct 27, 2020

Choose a reason for hiding this comment

tmbo left a comment

Choose a reason for hiding this comment

Henrike100 commented Sep 25, 2020 •

edited by erohmensing

Loading

CLAassistant commented Sep 25, 2020 •

edited

Loading

erohmensing Sep 25, 2020 •

edited

Loading