Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Releases3DS] Add support for Switch releases #1694

Merged
merged 3 commits into from
Aug 31, 2020
Merged

[Releases3DS] Add support for Switch releases #1694

merged 3 commits into from
Aug 31, 2020

Conversation

ORelio
Copy link
Contributor

@ORelio ORelio commented Aug 11, 2020

This pull request contains changes separated from #1507.

Request nswdb.com instead of 3dsdb.com for Switch releases.
The two websites are identical, only the URL changes.

Request nswdb.com instead of 3dsdb.com for Switch releases
@em92
Copy link
Contributor

em92 commented Aug 12, 2020

https://feed.eugenemolotov.ru/pr1694/?action=display&bridge=Releases3DS&console=switch&format=Html

Notice: Trying to get property 'href' of non-object in /var/www/rss-bridge/pr1694/bridges/Releases3DSBridge.php on line 73

Notice: Trying to get property 'src' of non-object in /var/www/rss-bridge/pr1694/bridges/Releases3DSBridge.php on line 71
  1. I chose "console: switch" but feed title links to 3ds. AFAIK 3ds and switch are different consoles from one manufacturer Nintendo.

Have you tried to make a separate bridge for nswdb just inheriting from 3dsdb bridge?

@ORelio
Copy link
Contributor Author

ORelio commented Aug 12, 2020

Thanks for reporting the notices, I'll have a look.
Making a separate bridge with inheritance could work, I'll attempt this 👍

Separate bridge from Releases3DS that just has a different URL.
Inherits from Releases3DS so both bridges need to be present.
@ORelio
Copy link
Contributor Author

ORelio commented Aug 27, 2020

Notices fixed and separate bridge done. Of course the separate bridge requires Releases3DS to be present.

@em92 em92 merged commit e00bbe3 into RSS-Bridge:master Aug 31, 2020
@em92
Copy link
Contributor

em92 commented Aug 31, 2020

gj @ORelio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants