Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multi] Minor improvements for my bridges #1507

Merged
merged 11 commits into from
Aug 14, 2020
Merged

[Multi] Minor improvements for my bridges #1507

merged 11 commits into from
Aug 14, 2020

Conversation

ORelio
Copy link
Contributor

@ORelio ORelio commented Mar 25, 2020

Hi,

Here are a few improvements for the bridges I am maintaining:

  • Anidex: Use alternate domain name to circumvent ddos-guard
  • Dark Reading: Hide dummy articles without content
  • FuturaSciences: Fix content extraction, strip inline scripts from content
  • GBAtemp: Fix content extraction in Tutorials mode
  • LeMondeInformatique: Remove encoding conversion
  • NextInpact: Fix article subtitle extraction
  • Releases3DS: Allow monitoring Nintendo Switch releases as well
  • TheHackerNews: Fix article author containing an invalid character

Also two minor fixes to the RSS-Bridge core:

  • FeedExpander: Fix PHP notice on empty uri field
  • Markdown: Fix images with empty alternative text

Changes are minor so I grouped them into a single Pull request. Hope you don't mind.

EDIT: As requested by @em92 in #1692, changes for Anidex and Releases3DS were removed from this PR.
EDIT: Also removed changes for NextInpact as the bridge is being reworked (#1692)

@somini
Copy link
Contributor

somini commented Apr 3, 2020

The rest LGTM.

@ORelio
Copy link
Contributor Author

ORelio commented May 15, 2020

Just added one more commit for AnimeUltime, similar to LeMondeInformatique:

  • AnimeUltime: Remove encoding conversion

@somini Any issue with this PR? "The rest" suggests something may be missing in your message.

Copy link
Contributor

@somini somini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@somini Any issue with this PR? "The rest" suggests something may be missing in your message.

I meant besides the other comments I did.

bridges/AnidexBridge.php Outdated Show resolved Hide resolved
bridges/Releases3DSBridge.php Outdated Show resolved Hide resolved
@ORelio
Copy link
Contributor Author

ORelio commented May 17, 2020

Thanks @somini, I could not see your comments until your last reply. I'll address them.

bridges/AnidexBridge.php Outdated Show resolved Hide resolved
(guid is valid uri AND item uri is not valid)
 => (guid is valid uri AND item uri is empty or not valid)
@ORelio
Copy link
Contributor Author

ORelio commented Aug 11, 2020

As requested by @em92 in #1692, changes for Anidex and Releases3DS were moved to #1693 and #1694, respectively.

@em92
Copy link
Contributor

em92 commented Aug 12, 2020

TheHackerNews - ok
Next Inpact - related #1692. Waiting for new version
LeMondeInformatique - ok
GBATemp - ok
FuturaScince - ok
AnimeUltime - ok
Darkreading - didn't find those dummy articles, but ok

FeedExpander and Markdown fixes - ok

I would merge this PR immediately if it didn't have Next Inpact commit. I suggest to take it external PR

@em92 em92 linked an issue Aug 12, 2020 that may be closed by this pull request
@ORelio
Copy link
Contributor Author

ORelio commented Aug 12, 2020

Thanks for your time in reviewing my pull requests 👍
Indeed, the NextInpact commit is not needed anymore as the bridge is being reworked. Removed it from the PR.
The Darkreading dummy articles are empty articles with only a title, they were polluting my feed reader a few months ago but maybe they stopped putting them in their RSS feed? Anyway, I think it does not hurt to keep the check for empty content, just in case.

@em92 em92 merged commit 4b8c3b9 into RSS-Bridge:master Aug 14, 2020
@em92
Copy link
Contributor

em92 commented Aug 14, 2020

Thanks @ORelio !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GBAtemp: Extraction fails in Tutorials mode
3 participants