Repository navigation
[hipFile] Implement execution of submitted batch operations. - #9991
Closed
jordan-turbofish wants to merge 12 commits into
Closed
jordan-turbofish wants to merge 12 commits into
jordan-turbofish wants to merge 12 commits into
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
3 times, most recently
from
August 18, 2026 20:09
82ff617 to
9db5202
Compare
jordan-turbofish
marked this pull request as ready for review
August 18, 2026 20:10
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
from
August 19, 2026 19:09
9db5202 to
6f1caf2
Compare
1 task
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
3 times, most recently
from
August 20, 2026 20:44
bd8b945 to
5cd0771
Compare
… versions Batch operations acquire the IFile and IBuffer before performing the IO. The IFile / IBuffer version rethrows the HipRuntime error. We will convert it to a hipFileDriverError in batch, since HIP errors would overlap with POXIX errors.
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
from
August 24, 2026 16:07
5cd0771 to
e4ee53c
Compare
Moves locking of DriverState out of the BatchContext, which could cause ordering issues when cleanup is done during a hipFileDriverClose.
Consts are removed from the IFile and IBuffer to match usage in hipFileIo.
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
from
August 25, 2026 20:43
e4ee53c to
c6d034f
Compare
riley-dixon
approved these changes
Aug 27, 2026
riley-dixon
left a comment
riley-dixon
left a comment
Contributor
There was a problem hiding this comment.
Only thing I can think of is adding some system tests if it is not premature.
| { | ||
| } | ||
|
|
||
| namespace batchOperationState { |
Contributor
There was a problem hiding this comment.
I don't really think it's necessary, but an idea I thought of here is asking an agent to document a graph here to visualize permissible state transitions. (Feel free to decline and resolve.)
zbyrne
approved these changes
Aug 28, 2026
jordan-turbofish
force-pushed
the
users/jpatters/hipfile-batch-submit
branch
from
August 31, 2026 16:03
c6d034f to
6442cc1
Compare
| outstanding_ops.insert(pending_ops.begin(), pending_ops.end()); | ||
|
|
||
| pending_ops.push_back(std::move(op)); | ||
| for (const auto &op : pending_ops) { |
Contributor
Author
|
Closed in favor of merging all batch functionality at once in #10430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR implements execution of the submitted batch operations on the thread pool, with some prior cleanup.
Depends on: #9659
Starts at commit: Use camel case for BatchContext methods.
Technical Details
Issue Tracking
Part of:
JIRA ID: AIHIPFILE-65
Test Plan
Unit tests added for new functionality.
Test Result
Tests pass.
Submission Checklist