Repository navigation
[hipfile] Add thread pool for batch operations. - #9659
Merged
Merged
Conversation
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
jordan-turbofish
marked this pull request as draft
August 4, 2026 21:34
jordan-turbofish
force-pushed
the
users/jpatters/batch-tp
branch
from
August 4, 2026 22:25
1e9d47d to
59e2768
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
jordan-turbofish
marked this pull request as ready for review
August 6, 2026 17:00
1 task
jordan-turbofish
force-pushed
the
users/jpatters/batch-tp
branch
from
August 18, 2026 16:22
9836066 to
fdddc20
Compare
kurtmcmillan
approved these changes
Aug 19, 2026
It is not UB and is used by Taskflow.
jordan-turbofish
force-pushed
the
users/jpatters/batch-tp
branch
from
August 19, 2026 18:37
fdddc20 to
18fdf1a
Compare
Disable a couple of false-positive warnings on thread-pool.cpp that are coming from Taskflow. Disable strict-overflow, which is buggy and triggers on std::algorithm usage. It has been removed in a later version of gcc.
Ensures any resources are released when a wait on the task group completes.
jordan-turbofish
force-pushed
the
users/jpatters/batch-tp
branch
from
August 20, 2026 20:43
ec009e5 to
dd41292
Compare
cmcknigh
pushed a commit
that referenced
this pull request
Aug 25, 2026
## Motivation Add thread pool for batch operations. ## Technical Details - Adds a thread pool for batch operations using Taskflow. - Fixes ASAN issues in unit test code. - Disables unsigned-shift-base check, which is not UB, and is used in Taskflow. - Enables sanitizer flags on test executables so that TSAN analysis works properly. - Disables warnings coming from Taskflow (most on stdlib headers, some false positives from SmallVec borrowed from LLVM llvm/llvm-project#159044) ## Issue Tracking Part of: JIRA ID: AIHIPFILE-65 ## Test Plan Unit tests added to thread pool. ## Test Result Tests pass. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
ajanicijamd
pushed a commit
that referenced
this pull request
Aug 25, 2026
## Motivation Add thread pool for batch operations. ## Technical Details - Adds a thread pool for batch operations using Taskflow. - Fixes ASAN issues in unit test code. - Disables unsigned-shift-base check, which is not UB, and is used in Taskflow. - Enables sanitizer flags on test executables so that TSAN analysis works properly. - Disables warnings coming from Taskflow (most on stdlib headers, some false positives from SmallVec borrowed from LLVM llvm/llvm-project#159044) ## Issue Tracking Part of: JIRA ID: AIHIPFILE-65 ## Test Plan Unit tests added to thread pool. ## Test Result Tests pass. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add thread pool for batch operations.
Technical Details
Issue Tracking
Part of:
JIRA ID: AIHIPFILE-65
Test Plan
Unit tests added to thread pool.
Test Result
Tests pass.
Submission Checklist