Skip to content

fix(rocjitsu): avoid plugin false-firing on D16 load completion - #8628

Merged
newling merged 2 commits into
ROCm:developfrom
newling:fix-rocjitsu-d16-false-positive
Jul 20, 2026
Merged

newling merged 2 commits into
ROCm:developfrom
newling:fix-rocjitsu-d16-false-positive

Conversation

@newling

@newling newling commented Jul 15, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Fixes a false positive in rocjitsu race detection for D16 vector memory loads (gfx1151)

D16 loads merge the loaded half into the destination VGPR while preserving the other half. Rocjitsu was reading the preserved half through the plugin-observed VGPR read path during memory completion, so the race detector could report a same-instruction self-conflict after the load event had already been registered.

This changes D16 memory completion to read the preserved destination half as internal storage state rather than as an instruction-visible VGPR read.

Tests

New tests added

@newling
newling requested review from a team and atgutier as code owners July 15, 2026 17:17
@therock-pr-bot

therock-pr-bot Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass —
📝 PR Title/Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jul 15, 2026 •

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@newling
newling force-pushed the fix-rocjitsu-d16-false-positive branch from 8e2d182 to ff3e269 Compare July 17, 2026 17:17

@lialan lialan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@newling
newling merged commit 8d474dd into ROCm:develop Jul 20, 2026
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants