Repository navigation
fix(rocjitsu): avoid plugin false-firing on D16 load completion - #8628
Merged
Merged
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
This was referenced Jul 15, 2026
newling
force-pushed
the
fix-rocjitsu-d16-false-positive
branch
from
July 17, 2026 17:17
8e2d182 to
ff3e269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes a false positive in rocjitsu race detection for D16 vector memory loads (gfx1151)
D16 loads merge the loaded half into the destination VGPR while preserving the other half. Rocjitsu was reading the preserved half through the plugin-observed VGPR read path during memory completion, so the race detector could report a same-instruction self-conflict after the load event had already been registered.
This changes D16 memory completion to read the preserved destination half as internal storage state rather than as an instruction-visible VGPR read.
Tests
New tests added