Skip to content

[SWDEV-551309] Adjusted rocmsmitst and --resetprofile command #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marifamd merged 2 commits into from
Sep 9, 2025
Merged

[SWDEV-551309] Adjusted rocmsmitst and --resetprofile command #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21c084a
[SWDEV-551309] Adjusted rocmsmitst and --resetprofile command
gabrpham Aug 26, 2025
ac1ca2e
Adjusted profile restoration after test check
gabrpham Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions projects/rocm-smi-lib/python_smi_tools/rocm_smi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,11 +1143,6 @@ def resetProfile(deviceList):
printLog(device, 'Successfully reset Power Profile', None)
else:
printErrLog(device, 'Unable to reset Power Profile')
ret = rocmsmi.rsmi_dev_perf_level_set(device, rsmi_dev_perf_level_t(0))
if rsmi_ret_ok(ret, device, 'set_perf_level'):
printLog(device, 'Successfully reset Performance Level', None)
else:
printErrLog(device, 'Unable to reset Performance Level')
printLogSpacer()


Expand Down
4 changes: 0 additions & 4 deletions projects/rocm-smi-lib/src/rocm_smi.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1301,10 +1301,6 @@ static rsmi_status_t get_power_profiles(uint32_t dv_ind,
}
assert(val_vec.size() <= RSMI_MAX_NUM_POWER_PROFILES);
if (val_vec.size() > RSMI_MAX_NUM_POWER_PROFILES + 1 || val_vec.empty()) {
// Guest may not have power related information.
if (amd::smi::is_vm_guest()) {
return RSMI_STATUS_NOT_SUPPORTED;
}
return RSMI_STATUS_UNEXPECTED_SIZE;
}
// -1 for the header line, below
Expand Down
21 changes: 7 additions & 14 deletions projects/rocm-smi-lib/tests/rocm_smi_test/functional/power_read_write.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void TestPowerReadWrite::Run(void) {
ASSERT_EQ(ret, RSMI_STATUS_NOT_SUPPORTED);
continue;
}
CHK_ERR_ASRT(ret)
CHK_ERR_ASRT(ret);

// Verify api support checking functionality is working
ret = rsmi_dev_power_profile_presets_get(dv_ind, 0, nullptr);
Expand Down Expand Up @@ -181,24 +181,17 @@ void TestPowerReadWrite::Run(void) {

rsmi_dev_perf_level_t pfl;
ret = rsmi_dev_perf_level_get(dv_ind, &pfl);
CHK_ERR_ASRT(ret)
CHK_ERR_ASRT(ret);
ASSERT_EQ(pfl, RSMI_DEV_PERF_LEVEL_MANUAL);

ret = rsmi_dev_power_profile_presets_get(dv_ind, 0, &status);
CHK_ERR_ASRT(ret)
CHK_ERR_ASRT(ret);

ASSERT_EQ(status.current, new_prof);

ret = rsmi_dev_perf_level_set(dv_ind, RSMI_DEV_PERF_LEVEL_AUTO);
CHK_ERR_ASRT(ret)

ret = rsmi_dev_perf_level_get(dv_ind, &pfl);
CHK_ERR_ASRT(ret)
ASSERT_EQ(pfl, RSMI_DEV_PERF_LEVEL_AUTO);

ret = rsmi_dev_power_profile_presets_get(dv_ind, 0, &status);
CHK_ERR_ASRT(ret)

ASSERT_EQ(status.current, orig_profile);
// Restore original power profile and performance level
// assertion check not necessary because we are restoring the original state
rsmi_dev_perf_level_set(dv_ind, RSMI_DEV_PERF_LEVEL_AUTO);
rsmi_dev_power_profile_set(dv_ind, 0, orig_profile);
}
}