Repository navigation
[SWDEV-551309] Adjusted rocmsmitst and --resetprofile command - #769
Merged
Merged
Conversation
gabrpham
requested review from
dmitrii-galantsev and
oliveiradan
as code owners
August 26, 2025 20:49
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adjusts ROCm SMI power profile and performance level handling to reflect new driver behavior where power_dpm_performance_level became independent from pp_power_profile_mode.
- Removed coupling between performance level and power profile operations
- Added missing semicolons to macro calls
- Removed VM guest power profile checks
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| power_read_write.cc | Fixed macro semicolons and simplified test logic by removing performance level dependency |
| rocm_smi.cc | Removed VM guest check for power profile operations |
| rocm_smi.py | Removed performance level reset from resetProfile command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marifamd
requested changes
Aug 28, 2025
marifamd
force-pushed
the
users/gabrpham/SWDEV-551309
branch
from
August 28, 2025 16:51
381742d to
7475f18
Compare
gabrpham
force-pushed
the
users/gabrpham/SWDEV-551309
branch
2 times, most recently
from
August 28, 2025 17:58
691ac5c to
e2235f7
Compare
marifamd
approved these changes
Aug 29, 2025
marifamd
force-pushed
the
users/gabrpham/SWDEV-551309
branch
3 times, most recently
from
September 2, 2025 14:59
f68bbf2 to
84571db
Compare
4 of 15 tasks
Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>
gabrpham
force-pushed
the
users/gabrpham/SWDEV-551309
branch
from
September 8, 2025 18:22
84571db to
ac1ca2e
Compare
oliveiradan
approved these changes
Sep 8, 2025
systems-assistant Bot
pushed a commit
to ROCm/rocm_smi_lib
that referenced
this pull request
Sep 9, 2025
(#769) [rocm-systems] ROCm/rocm-systems#769 (commit 5dbca01)
jharryma
pushed a commit
that referenced
this pull request
Sep 12, 2025
jharryma
pushed a commit
that referenced
this pull request
Sep 12, 2025
[ROCm/rocprofiler-compute commit: 9ddee8d]
sauverma93
pushed a commit
that referenced
this pull request
Sep 26, 2025
1 task
erman-gurses
pushed a commit
that referenced
this pull request
Nov 4, 2026
…mAdvise_TstAccessedByFlg4 (#14467) ## Motivation windows and wsl, test is already skipped by CHECK_MANAGED_MEMORY_SUPPORT ## Technical Details After discussion, removing disabled tag is a valid solution. There is a new unsupported tag for skipping the test on the yaml file. But just removing the disabled tag follows the convention, as most managed memory tests just rely on CHECK_MANAGED_MEMORY_SUPPORT skipping the test on windows. ## Issue Tracking JIRA ID: AIRUNTIME 2291 ## Test Plan ctest -R "Unit_hipMemAdvise_TstAccessedByFlg4" -V ## Test Result 769: C:/develop/zifan/TheRock/rocm-systems/projects/hip-tests/catch/unit/memory/hipMemAdvise_old.cc(203): SKIPPED: 769: explicitly with message: 769: GPU does not support managed memory. 769: 769: ================================================================================ 769: test cases: 1 | 1 skipped 769: assertions: - none - 769: 1/1 Test #769: Unit_hipMemAdvise_TstAccessedByFlg4 ...***Skipped 0.92 sec ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/rocm-systems/blob/develop/CONTRIBUTING.md. Co-authored-by: zifan <zifan@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Change in driver behavior expectation required update to the test and --resetprofile command
Technical Details
Power_dpm_performance_level became completely independent from pp_power_profile_mode so rocm-smi was also updated accordingly.
Test Plan
rocmsmitst should now pass the rsmitstReadWrite.TestPowerReadWrite test
Test Result
rsmitstReadWrite.TestPowerReadWrite was passed
Submission Checklist