Repository navigation
feat: [rocjitsu] Flag-Dependent Read/Write Liveness - #7384
Merged
Merged
Conversation
Adds the destination register for SDWA and DPP instructions as a source so that InstDefUse and liveness analysis work soundly. Addresses issue #7033.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
theSK2005
changed the title
theSK2005
changed the title
theSK2005
changed the title
accauble
approved these changes
Jun 26, 2026
accauble
left a comment
accauble
left a comment
Contributor
There was a problem hiding this comment.
Approving but please confirm that you have looked for other examples of rw issues and did not find any. I would also like @Groverkss to sign off.
Pre-commit check failed⛔ pre-commit failed Please run locally:
This repo uses |
Groverkss
reviewed
Jul 3, 2026
…auses oob writes to retain the prior vdst values (partial write)
kuhar
reviewed
Jul 10, 2026
…n't hardcoded, added test case that tests width = 2 instruction
kuhar
reviewed
Jul 10, 2026
…lator (doesn't currently restore SGPRs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds the destination register for SDWA (dst_unused:preserved) and DPP (partial mask) instructions as a source so that InstDefUse and liveness analysis work soundly. Addresses issue #7033. PR #8344 is a followup.
Test Plan
Wrote some tests cases that decode SDWA and DPP instructions that do and don't keep prior register values and checked if uses were stored properly.
Test Result
Passed new tests and all previous tests.