Skip to content

[rocprofiler-systems] - add suffix to libomptarget find_library - #7334

Merged
estewart08 merged 15 commits into
developfrom
amd/dev/estewart/rocprofiler-systems-libomptarget-search
Jul 9, 2026
Merged

[rocprofiler-systems] - add suffix to libomptarget find_library#7334
estewart08 merged 15 commits into
developfrom
amd/dev/estewart/rocprofiler-systems-libomptarget-search

Conversation

@estewart08

@estewart08 estewart08 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This is in prepartion for compiler using LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON by default. This option will install libomptarget.so in a target specific directory one level down in lib. Then the path would be: /lib/llvm/lib/x86_64-unknown-linux-gnu.

This is required for ROCm/TheRock#5758

@estewart08
estewart08 requested review from a team and jrmadsen as code owners June 16, 2026 18:28
@kcossett-amd

kcossett-amd commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

This change should probably also be added to the following:

@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Unit Tests

Code Coverage: unit-tests

Lines: 🔴 12.9% — 4,105/31,708 across 266 files
Functions: 🔴 12.6% — 414/3,284

🔴 0-20% (200 files)
Lines Functions File
0.0% 0/105 0/9 source/bin/common/argument_registration.hpp
0.0% 0/259 0/29 source/bin/common/tool_runner.cpp
0.0% 0/931 0/47 source/bin/rocprof-sys-avail/avail.cpp
0.0% 0/61 0/6 source/bin/rocprof-sys-avail/avail.hpp
0.0% 0/231 0/26 source/bin/rocprof-sys-avail/common.cpp
0.0% 0/17 0/3 source/bin/rocprof-sys-avail/component_categories.hpp
0.0% 0/257 0/12 source/bin/rocprof-sys-avail/generate_config.cpp
0.0% 0/39 0/2 source/bin/rocprof-sys-avail/get_availability.hpp
0.0% 0/10 0/1 source/bin/rocprof-sys-avail/get_categories.hpp
0.0% 0/102 0/6 source/bin/rocprof-sys-avail/hw_counter_query.cpp
0.0% 0/4 0/1 source/bin/rocprof-sys-avail/info_type.cpp
0.0% 0/9 0/1 source/bin/rocprof-sys-avail/info_type.hpp
0.0% 0/440 0/47 source/bin/rocprof-sys-causal/impl.cpp
0.0% 0/80 0/2 source/bin/rocprof-sys-causal/rocprof-sys-causal.cpp
0.0% 0/588 0/42 source/bin/rocprof-sys-instrument/details.cpp
0.0% 0/93 0/7 source/bin/rocprof-sys-instrument/function_signature.cpp
0.0% 0/20 0/5 source/bin/rocprof-sys-instrument/function_signature.hpp
0.0% 0/156 0/7 source/bin/rocprof-sys-instrument/info.hpp
0.0% 0/261 0/22 source/bin/rocprof-sys-instrument/internal_libs.cpp
0.0% 0/63 0/6 source/bin/rocprof-sys-instrument/log.cpp
0.0% 0/5 0/1 source/bin/rocprof-sys-instrument/log.hpp
0.0% 0/529 0/40 source/bin/rocprof-sys-instrument/module_function.cpp
0.0% 0/93 0/7 source/bin/rocprof-sys-instrument/module_function.hpp
0.0% 0/1572 0/88 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp
0.0% 0/167 0/12 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.hpp
0.0% 0/2 0/1 source/bin/rocprof-sys-run/rocprof-sys-run.cpp
0.0% 0/2 0/1 source/bin/rocprof-sys-sample/rocprof-sys-sample.cpp
0.0% 0/22 0/1 source/lib/backends/amd_smi/wrapper.hpp
0.0% 0/43 0/2 source/lib/backends/rocprofiler_sdk/backend.hpp
0.0% 0/16 0/4 source/lib/binary/address_multirange.cpp
0.0% 0/9 0/1 source/lib/binary/address_multirange.hpp
0.0% 0/117 0/5 source/lib/binary/analysis.cpp
0.0% 0/7 0/1 source/lib/binary/binary_info.hpp
0.0% 0/102 0/9 source/lib/binary/dwarf_entry.cpp
0.0% 0/1 0/1 source/lib/binary/dwarf_entry.hpp
0.0% 0/69 0/6 source/lib/binary/link_map.cpp
0.0% 0/3 0/1 source/lib/binary/link_map.hpp
0.0% 0/10 0/1 source/lib/binary/scope_filter.cpp
0.0% 0/5 0/2 source/lib/binary/scope_filter.hpp
0.0% 0/159 0/18 source/lib/binary/symbol.cpp
0.0% 0/8 0/8 source/lib/binary/symbol.hpp
0.0% 0/9 0/2 source/lib/common/env_vars.hpp
0.0% 0/36 0/3 source/lib/common/invoke.hpp
0.0% 0/164 0/14 source/lib/common/md5sum.hpp
0.0% 0/20 0/2 source/lib/common/setup.hpp
0.0% 0/22 0/3 source/lib/common/static_object.hpp
0.0% 0/10 0/3 source/lib/common/synchronized.hpp
0.0% 0/3 0/1 source/lib/common/units.hpp
0.0% 0/166 0/2 source/lib/core/agent_info.hpp
0.0% 0/33 0/3 source/lib/core/amd_smi.cpp
0.0% 0/80 0/18 source/lib/core/binary/address_range.cpp
0.0% 0/9 0/3 source/lib/core/binary/address_range.hpp
0.0% 0/49 0/10 source/lib/core/categories.cpp
0.0% 0/11 0/11 source/lib/core/components/fwd.hpp
0.0% 0/26 0/3 source/lib/core/config.hpp
0.0% 0/14 0/2 source/lib/core/containers/aligned_static_vector.hpp
0.0% 0/11 0/3 source/lib/core/containers/c_array.hpp
0.0% 0/1 0/1 source/lib/core/containers/operators.hpp
0.0% 0/46 0/12 source/lib/core/containers/stable_vector.hpp
0.0% 0/23 0/5 source/lib/core/containers/static_vector.hpp
0.0% 0/89 0/6 source/lib/core/cpu.cpp
0.0% 0/1 0/1 source/lib/core/cpu.hpp
0.0% 0/53 0/6 source/lib/core/dynamic_library.cpp
0.0% 0/28 0/7 source/lib/core/exception.cpp
0.0% 0/163 0/22 source/lib/core/gpu.cpp
0.0% 0/160 0/12 source/lib/core/gpu_metrics.cpp
0.0% 0/32 0/6 source/lib/core/mpi.hpp
0.0% 0/56 0/4 source/lib/core/mproc.cpp
0.0% 0/24 0/2 source/lib/core/node_info.cpp
0.0% 0/2 0/2 source/lib/core/node_info.hpp
0.0% 0/48 0/5 source/lib/core/output_file_registry.cpp
0.0% 0/1 0/1 source/lib/core/output_file_registry.hpp
0.0% 0/79 0/5 source/lib/core/perf.cpp
0.0% 0/166 0/13 source/lib/core/perfetto.cpp
0.0% 0/57 0/7 source/lib/core/perfetto.hpp
0.0% 0/1 0/1 source/lib/core/progress/bar.hpp
0.0% 0/290 0/33 source/lib/core/rocpd/data_processor.cpp
0.0% 0/7 0/3 source/lib/core/rocpd/data_processor.hpp
0.0% 0/73 0/11 source/lib/core/rocpd/data_storage/database.cpp
0.0% 0/49 0/6 source/lib/core/rocpd/data_storage/database.hpp
0.0% 0/28 0/4 source/lib/core/rocpd/data_storage/insert_query_builders.hpp
0.0% 0/7 0/2 source/lib/core/rocpd/data_storage/table_insert_query.hpp
0.0% 0/342 0/22 source/lib/core/rocprofiler-sdk.cpp
0.0% 0/40 0/3 source/lib/core/trace_cache/cache_manager.cpp
0.0% 0/7 0/3 source/lib/core/trace_cache/cache_manager.hpp
0.0% 0/516 0/71 source/lib/core/trace_cache/metadata_registry.cpp
0.0% 0/893 0/112 source/lib/core/trace_cache/perfetto_processor.cpp
0.0% 0/102 0/10 source/lib/core/trace_cache/post_processor.cpp
0.0% 0/589 0/34 source/lib/core/trace_cache/rocpd_processor.cpp
0.0% 0/77 0/1 source/lib/core/trace_cache/sample_processor.hpp
0.0% 0/44 0/4 source/lib/core/utility.cpp
0.0% 0/544 0/90 source/lib/rocprof-sys-dl/dl.cpp
0.0% 0/16 0/1 source/lib/rocprof-sys-dl/main.c
0.0% 0/280 0/31 source/lib/rocprof-sys-rt/src/RTcommon.c
0.0% 0/29 0/4 source/lib/rocprof-sys-rt/src/RTheap-linux.c
0.0% 0/65 0/4 source/lib/rocprof-sys-rt/src/RTheap.c
0.0% 0/212 0/22 source/lib/rocprof-sys-rt/src/RTlinux.c
0.0% 0/97 0/8 source/lib/rocprof-sys-rt/src/RTposix.c
0.0% 0/6 0/2 source/lib/rocprof-sys-rt/src/RTsignal.c
0.0% 0/11 0/2 source/lib/rocprof-sys-rt/src/RTthread-x86-64.c
0.0% 0/3 0/1 source/lib/rocprof-sys-rt/src/RTthread.c
0.0% 0/79 0/13 source/lib/rocprof-sys-user/user.cpp
0.0% 0/70 0/18 source/lib/rocprof-sys/api.cpp
0.0% 0/621 0/36 source/lib/rocprof-sys/library.cpp
0.0% 0/77 0/6 source/lib/rocprof-sys/library/causal/components/backtrace.cpp
0.0% 0/7 0/2 source/lib/rocprof-sys/library/causal/components/backtrace.hpp
0.0% 0/93 0/11 source/lib/rocprof-sys/library/causal/components/blocking_gotcha.cpp
0.0% 0/33 0/7 source/lib/rocprof-sys/library/causal/components/causal_gotcha.cpp
0.0% 0/85 0/22 source/lib/rocprof-sys/library/causal/components/progress_point.cpp
0.0% 0/23 0/3 source/lib/rocprof-sys/library/causal/components/progress_point.hpp
0.0% 0/44 0/8 source/lib/rocprof-sys/library/causal/components/unblocking_gotcha.cpp
0.0% 0/551 0/33 source/lib/rocprof-sys/library/causal/data.cpp
0.0% 0/87 0/16 source/lib/rocprof-sys/library/causal/delay.cpp
0.0% 0/373 0/29 source/lib/rocprof-sys/library/causal/experiment.cpp
0.0% 0/3 0/2 source/lib/rocprof-sys/library/causal/experiment.hpp
0.0% 0/24 0/5 source/lib/rocprof-sys/library/causal/sample_data.cpp
0.0% 0/269 0/25 source/lib/rocprof-sys/library/causal/sampling.cpp
0.0% 0/4 0/1 source/lib/rocprof-sys/library/causal/selected_entry.cpp
0.0% 0/5 0/3 source/lib/rocprof-sys/library/causal/selected_entry.hpp
0.0% 0/71 0/11 source/lib/rocprof-sys/library/components/backtrace.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/backtrace.hpp
0.0% 0/218 0/30 source/lib/rocprof-sys/library/components/backtrace_metrics.cpp
0.0% 0/11 0/2 source/lib/rocprof-sys/library/components/backtrace_metrics.hpp
0.0% 0/9 0/3 source/lib/rocprof-sys/library/components/backtrace_timestamp.cpp
0.0% 0/4 0/2 source/lib/rocprof-sys/library/components/backtrace_timestamp.hpp
0.0% 0/71 0/10 source/lib/rocprof-sys/library/components/callchain.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/callchain.hpp
0.0% 0/367 0/30 source/lib/rocprof-sys/library/components/comm_data.cpp
0.0% 0/19 0/5 source/lib/rocprof-sys/library/components/comm_data.hpp
0.0% 0/8 0/2 source/lib/rocprof-sys/library/components/ensure_storage.hpp
0.0% 0/28 0/6 source/lib/rocprof-sys/library/components/exit_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/exit_gotcha.hpp
0.0% 0/67 0/8 source/lib/rocprof-sys/library/components/fork_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/fork_gotcha.hpp
0.0% 0/13 0/3 source/lib/rocprof-sys/library/components/kill_gotcha.cpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/kill_gotcha.hpp
0.0% 0/158 0/22 source/lib/rocprof-sys/library/components/mpi_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/mpi_gotcha.hpp
0.0% 0/533 0/12 source/lib/rocprof-sys/library/components/mpip.hpp
0.0% 0/78 0/19 source/lib/rocprof-sys/library/components/numa_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/numa_gotcha.hpp
0.0% 0/323 0/20 source/lib/rocprof-sys/library/components/pthread_create_gotcha.cpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/components/pthread_create_gotcha.hpp
0.0% 0/34 0/9 source/lib/rocprof-sys/library/components/pthread_gotcha.cpp
0.0% 0/23 0/2 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha_policy.hpp
0.0% 0/164 0/31 source/lib/rocprof-sys/library/components/vaapi_gotcha.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/components/vaapi_gotcha.hpp
0.0% 0/145 0/10 source/lib/rocprof-sys/library/coverage.cpp
0.0% 0/29 0/5 source/lib/rocprof-sys/library/coverage.hpp
0.0% 0/60 0/16 source/lib/rocprof-sys/library/coverage/impl.hpp
0.0% 0/254 0/37 source/lib/rocprof-sys/library/kokkosp.cpp
0.0% 0/245 0/31 source/lib/rocprof-sys/library/perf.cpp
0.0% 0/11 0/3 source/lib/rocprof-sys/library/perf.hpp
0.0% 0/182 0/11 source/lib/rocprof-sys/library/pmc/collectors/common/settings.hpp
0.0% 0/66 0/5 source/lib/rocprof-sys/library/pmc/collectors/cpu/cache_policy.hpp
0.0% 0/47 0/6 source/lib/rocprof-sys/library/pmc/collectors/cpu/cpu_traits.hpp
0.0% 0/52 0/9 source/lib/rocprof-sys/library/pmc/collectors/cpu/perfetto_policy.hpp
0.0% 0/100 0/6 source/lib/rocprof-sys/library/pmc/collectors/gpu/cache_policy.hpp
0.0% 0/40 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/gpu_traits.hpp
0.0% 0/222 0/36 source/lib/rocprof-sys/library/pmc/collectors/gpu/perfetto_policy.hpp
0.0% 0/25 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/sample.hpp
0.0% 0/32 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/cache_policy.hpp
0.0% 0/39 0/7 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/perfetto_policy.hpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/pmc/collectors/nic/sample.hpp
0.0% 0/14 0/2 source/lib/rocprof-sys/library/pmc/device_providers/procfs/provider.hpp
0.0% 0/148 0/18 source/lib/rocprof-sys/library/pmc/sampler.cpp
0.0% 0/112 0/11 source/lib/rocprof-sys/library/process_sampler.cpp
0.0% 0/13 0/1 source/lib/rocprof-sys/library/process_sampler.hpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/rocm.cpp
0.0% 0/1307 0/88 source/lib/rocprof-sys/library/rocprofiler-sdk.cpp
0.0% 0/110 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
0.0% 0/17 0/6 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.hpp
0.0% 0/129 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.cpp
0.0% 0/34 0/7 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.hpp
0.0% 0/265 0/25 source/lib/rocprof-sys/library/rocprofiler-sdk/kfd_events.cpp
0.0% 0/36 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.cpp
0.0% 0/136 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl.cpp
0.0% 0/112 0/10 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.cpp
0.0% 0/118 0/20 source/lib/rocprof-sys/library/runtime.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/runtime.hpp
0.0% 0/995 0/65 source/lib/rocprof-sys/library/sampling.cpp
0.0% 0/145 0/31 source/lib/rocprof-sys/library/thread_data.hpp
0.0% 0/10 0/3 source/lib/rocprof-sys/library/thread_data_growth.hpp
0.0% 0/10 0/1 source/lib/rocprof-sys/library/thread_deleter.cpp
0.0% 0/5 0/1 source/lib/rocprof-sys/library/thread_deleter.hpp
0.0% 0/148 0/25 source/lib/rocprof-sys/library/thread_info.cpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/thread_info.hpp
0.0% 0/118 0/13 source/lib/rocprof-sys/library/tracing.cpp
0.0% 0/132 0/32 source/lib/rocprof-sys/library/tracing.hpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/tracing/annotation.cpp
0.0% 0/45 0/4 source/lib/rocprof-sys/library/tracing/annotation.hpp
0.0% 0/8 0/2 source/lib/rocprof-sys/progress.cpp
0.0% 0/36 0/10 source/lib/rocprof-sys/regions.cpp
0.0% 0/82 0/4 source/lib/rocprof-sys/timeout.cpp
0.0% 0/457 0/46 source/python/libpyrocprofsys.cpp
0.8% 7/859 1/74 source/lib/core/argparse.cpp
2.5% 42/1708 7/289 source/lib/core/config.cpp
8.7% 15/172 3/25 source/lib/core/constraint.cpp
15.4% 4/26 0/6 source/lib/core/trace_cache/metadata_registry.hpp
16.7% 6/36 2/5 source/bin/common/common_utils.hpp
🟠 20-50% (7 files)
Lines Functions File
20.0% 1/5 0/2 source/lib/core/argparse.hpp
21.3% 13/61 3/9 source/lib/core/utility.hpp
22.2% 2/9 0/6 source/lib/core/constraint.hpp
23.8% 15/63 3/12 source/lib/core/agent_manager.cpp
31.1% 23/74 6/14 source/lib/core/state.cpp
42.9% 12/28 1/4 source/lib/common/join.hpp
47.4% 176/371 18/30 source/bin/common/common_utils.cpp
🟡 50-80% (16 files)
Lines Functions File
50.0% 127/254 14/33 source/lib/rocprof-sys/library/components/category_region.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/pmc/collectors/nic/types.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/pmc/common/types.hpp
52.0% 13/25 2/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/gpu_perf_counter_traits.hpp
55.7% 34/61 5/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/sample.hpp
60.0% 3/5 1/1 source/lib/core/agent.hpp
62.1% 41/66 7/8 source/lib/rocprof-sys/library/pmc/collectors/base/collector.hpp
62.3% 48/77 4/5 source/lib/core/trace_cache/discovery.cpp
63.1% 70/111 7/10 source/lib/core/progress/bar.cpp
64.1% 336/524 26/40 source/bin/common/json_config.cpp
66.7% 2/3 0/2 source/lib/rocprof-sys/library/pmc/collectors/cpu/types.hpp
67.2% 43/64 11/14 source/lib/core/trace_cache/data_types.cpp
68.8% 22/32 3/8 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/types.hpp
72.5% 216/298 14/16 source/bin/common/preset_registry.cpp
75.0% 3/4 0/1 source/lib/backends/amd_smi/nic_types.hpp
78.1% 107/137 13/15 source/lib/common/path.hpp
🟢 80-100% (43 files)
Lines Functions File
80.3% 61/76 8/9 source/lib/rocprof-sys/library/pmc/device_providers/rocprofiler_sdk/provider.hpp
83.9% 135/161 12/16 source/lib/backends/procfs/backend.hpp
84.6% 11/13 2/4 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.hpp
84.8% 84/99 11/15 source/lib/logger/logger.hpp
85.1% 40/47 2/2 source/lib/core/trace_cache/storage_parser.hpp
87.7% 265/302 27/32 source/lib/common/environment.hpp
89.1% 49/55 4/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/device.hpp
90.0% 54/60 4/4 source/lib/core/trace_cache/buffer_storage.cpp
90.1% 100/111 8/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/device.hpp
90.7% 303/334 28/31 source/lib/core/trace_cache/sample_type.hpp
91.0% 243/267 19/20 source/lib/core/trace_cache/unified_memory_processor.cpp
91.3% 178/195 14/18 source/lib/rocprof-sys/library/components/shmem_gotcha.hpp
92.3% 156/169 8/8 source/lib/rocprof-sys/library/pmc/collectors/gpu/device.hpp
92.7% 38/41 6/11 source/lib/core/demangler.hpp
92.9% 13/14 0/1 source/lib/rocprof-sys/library/pmc/collectors/common/collector_slice.hpp
93.0% 66/71 7/8 source/lib/core/trace_cache/buffer_storage.hpp
94.7% 54/57 6/8 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha.hpp
94.8% 55/58 1/5 source/lib/core/trace_cache/cacheable.hpp
94.8% 92/97 9/10 source/lib/rocprof-sys/library/rocprofiler-sdk/trace_control.cpp
95.8% 23/24 1/2 source/lib/common/delimit.hpp
95.9% 162/169 19/22 source/lib/rocprof-sys/library/components/ucx_gotcha.hpp
96.8% 30/31 3/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/sample.hpp
97.3% 73/75 6/6 source/lib/core/common_types.hpp
97.8% 45/46 7/7 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl_internal.hpp
97.9% 47/48 3/3 source/lib/rocprof-sys/library/pmc/collectors/nic/device.hpp
98.1% 51/52 7/7 source/lib/rocprof-sys/library/pmc/device_providers/amd_smi/provider.hpp
98.6% 73/74 14/15 source/lib/backends/amd_smi/backend.hpp
100.0% 1/1 0/1 source/bin/common/json_config.hpp
100.0% 105/105 13/14 source/lib/backends/amd_smi/device.hpp
100.0% 7/7 0/1 source/lib/backends/amd_smi/gpu_types.hpp
100.0% 1/1 0/1 source/lib/backends/rocprofiler_sdk/types.hpp
100.0% 3/3 0/1 source/lib/common/span.hpp
100.0% 2/2 0/2 source/lib/core/agent_manager.hpp
100.0% 6/6 2/2 source/lib/core/progress/tracker.cpp
100.0% 1/1 0/1 source/lib/core/progress/tracker.hpp
100.0% 2/2 0/1 source/lib/core/state.hpp
100.0% 4/4 0/3 source/lib/core/trace_cache/data_types.hpp
100.0% 9/9 3/3 source/lib/core/trace_cache/type_registry.hpp
100.0% 24/24 4/5 source/lib/core/trace_cache/unified_memory_processor.hpp
100.0% 10/10 1/1 source/lib/logger/logger.cpp
100.0% 9/9 0/2 source/lib/rocprof-sys/library/pmc/collectors/gpu/types.hpp
100.0% 34/34 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.hpp
100.0% 3/3 1/2 source/lib/rocprof-sys/library/rocprofiler-sdk/trace_control.hpp

Distribution

Range Files
0-20% 200
20-50% 7
50-80% 16
80-100% 43

E2E Tests

Code Coverage: e2e-tests

Lines: 🟡 62.4% — 19,781/31,708 across 266 files
Functions: 🟡 62.4% — 2,049/3,284

🔴 0-20% (46 files)
Lines Functions File
0.0% 0/102 0/6 source/bin/rocprof-sys-avail/hw_counter_query.cpp
0.0% 0/22 0/1 source/lib/backends/amd_smi/wrapper.hpp
0.0% 0/43 0/2 source/lib/backends/rocprofiler_sdk/backend.hpp
0.0% 0/166 0/2 source/lib/core/agent_info.hpp
0.0% 0/89 0/6 source/lib/core/cpu.cpp
0.0% 0/1 0/1 source/lib/core/cpu.hpp
0.0% 0/53 0/6 source/lib/core/dynamic_library.cpp
0.0% 0/28 0/7 source/lib/core/exception.cpp
0.0% 0/160 0/12 source/lib/core/gpu_metrics.cpp
0.0% 0/79 0/5 source/lib/core/perf.cpp
0.0% 0/7 0/3 source/lib/core/rocpd/data_processor.hpp
0.0% 0/6 0/2 source/lib/rocprof-sys-rt/src/RTsignal.c
0.0% 0/11 0/2 source/lib/rocprof-sys-rt/src/RTthread-x86-64.c
0.0% 0/3 0/1 source/lib/rocprof-sys-rt/src/RTthread.c
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/exit_gotcha.hpp
0.0% 0/1 0/1 source/lib/rocprof-sys/library/components/kill_gotcha.hpp
0.0% 0/164 0/31 source/lib/rocprof-sys/library/components/vaapi_gotcha.cpp
0.0% 0/52 0/9 source/lib/rocprof-sys/library/pmc/collectors/cpu/perfetto_policy.hpp
0.0% 0/100 0/6 source/lib/rocprof-sys/library/pmc/collectors/gpu/cache_policy.hpp
0.0% 0/40 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/gpu_traits.hpp
0.0% 0/222 0/36 source/lib/rocprof-sys/library/pmc/collectors/gpu/perfetto_policy.hpp
0.0% 0/25 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu/sample.hpp
0.0% 0/32 0/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/cache_policy.hpp
0.0% 0/39 0/7 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/perfetto_policy.hpp
0.0% 0/16 0/2 source/lib/rocprof-sys/library/pmc/collectors/nic/sample.hpp
0.0% 0/2 0/1 source/lib/rocprof-sys/library/rocm.cpp
0.0% 0/110 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.cpp
0.0% 0/17 0/6 source/lib/rocprof-sys/library/rocprofiler-sdk/counters.hpp
0.0% 0/129 0/9 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.cpp
0.0% 0/34 0/7 source/lib/rocprof-sys/library/rocprofiler-sdk/fwd.hpp
0.0% 0/265 0/25 source/lib/rocprof-sys/library/rocprofiler-sdk/kfd_events.cpp
0.0% 0/136 0/13 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl.cpp
0.0% 0/112 0/10 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.cpp
0.0% 0/3 0/1 source/lib/rocprof-sys/library/tracing/annotation.cpp
0.0% 0/457 0/46 source/python/libpyrocprofsys.cpp
0.6% 1/166 1/13 source/lib/core/perfetto.cpp
2.5% 33/1307 3/88 source/lib/rocprof-sys/library/rocprofiler-sdk.cpp
6.1% 2/33 1/3 source/lib/core/amd_smi.cpp
8.3% 3/36 1/9 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.cpp
11.1% 5/45 1/4 source/lib/rocprof-sys/library/tracing/annotation.hpp
11.3% 8/71 4/10 source/lib/rocprof-sys/library/components/callchain.cpp
13.6% 38/280 7/31 source/lib/rocprof-sys-rt/src/RTcommon.c
13.8% 4/29 1/4 source/lib/rocprof-sys-rt/src/RTheap-linux.c
14.2% 30/212 4/22 source/lib/rocprof-sys-rt/src/RTlinux.c
17.3% 102/589 7/34 source/lib/core/trace_cache/rocpd_processor.cpp
19.6% 32/163 6/22 source/lib/core/gpu.cpp
🟠 20-50% (20 files)
Lines Functions File
22.2% 76/342 8/22 source/lib/core/rocprofiler-sdk.cpp
22.5% 49/218 5/30 source/lib/rocprof-sys/library/components/backtrace_metrics.cpp
23.6% 122/516 24/71 source/lib/core/trace_cache/metadata_registry.cpp
27.8% 27/97 4/8 source/lib/rocprof-sys-rt/src/RTposix.c
32.4% 59/182 6/11 source/lib/rocprof-sys/library/pmc/collectors/common/settings.hpp
35.3% 315/893 34/112 source/lib/core/trace_cache/perfetto_processor.cpp
35.7% 10/28 3/6 source/lib/rocprof-sys/library/components/exit_gotcha.cpp
38.5% 5/13 2/3 source/lib/rocprof-sys/library/components/kill_gotcha.cpp
38.8% 31/80 1/2 source/bin/rocprof-sys-causal/rocprof-sys-causal.cpp
39.8% 37/93 5/11 source/lib/rocprof-sys/library/causal/components/blocking_gotcha.cpp
41.3% 26/63 7/12 source/lib/core/agent_manager.cpp
43.9% 36/82 2/4 source/lib/rocprof-sys/timeout.cpp
44.4% 4/9 1/3 source/lib/rocprof-sys/library/components/backtrace_timestamp.cpp
44.9% 22/49 4/6 source/lib/core/rocpd/data_storage/database.hpp
45.0% 27/60 6/16 source/lib/rocprof-sys/library/coverage/impl.hpp
46.2% 72/156 3/7 source/bin/rocprof-sys-instrument/info.hpp
46.2% 36/78 6/19 source/lib/rocprof-sys/library/components/numa_gotcha.cpp
47.7% 31/65 3/4 source/lib/rocprof-sys-rt/src/RTheap.c
48.5% 178/367 16/30 source/lib/rocprof-sys/library/components/comm_data.cpp
49.4% 39/79 6/13 source/lib/rocprof-sys-user/user.cpp
🟡 50-80% (55 files)
Lines Functions File
50.0% 8/16 2/4 source/lib/binary/address_multirange.cpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/components/numa_gotcha.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/components/vaapi_gotcha.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/pmc/collectors/nic/types.hpp
50.0% 1/2 0/1 source/lib/rocprof-sys/library/thread_info.hpp
50.0% 66/132 16/32 source/lib/rocprof-sys/library/tracing.hpp
50.0% 4/8 1/2 source/lib/rocprof-sys/progress.cpp
50.4% 128/254 25/37 source/lib/rocprof-sys/library/kokkosp.cpp
52.0% 13/25 2/3 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/gpu_perf_counter_traits.hpp
52.6% 30/57 4/7 source/lib/core/perfetto.hpp
53.2% 41/77 0/1 source/lib/core/trace_cache/sample_processor.hpp
53.4% 79/148 12/18 source/lib/rocprof-sys/library/pmc/sampler.cpp
55.7% 39/70 13/18 source/lib/rocprof-sys/api.cpp
58.0% 142/245 20/31 source/lib/rocprof-sys/library/perf.cpp
60.0% 63/105 5/9 source/bin/common/argument_registration.hpp
60.0% 3/5 1/1 source/lib/core/agent.hpp
61.1% 22/36 1/3 source/lib/common/invoke.hpp
61.9% 616/995 51/65 source/lib/rocprof-sys/library/sampling.cpp
62.5% 50/80 13/18 source/lib/core/binary/address_range.cpp
62.7% 42/67 5/8 source/lib/rocprof-sys/library/components/fork_gotcha.cpp
63.1% 70/111 7/10 source/lib/core/progress/bar.cpp
65.7% 113/172 17/25 source/lib/core/constraint.cpp
66.1% 37/56 3/4 source/lib/core/mproc.cpp
67.1% 106/158 14/22 source/lib/rocprof-sys/library/components/mpi_gotcha.cpp
67.9% 197/290 21/33 source/lib/core/rocpd/data_processor.cpp
68.6% 81/118 15/20 source/lib/rocprof-sys/library/runtime.cpp
68.8% 22/32 3/8 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/types.hpp
69.2% 18/26 2/6 source/lib/core/trace_cache/metadata_registry.hpp
69.2% 9/13 0/1 source/lib/rocprof-sys/library/process_sampler.hpp
69.7% 46/66 7/8 source/lib/rocprof-sys/library/pmc/collectors/base/collector.hpp
70.6% 24/34 5/9 source/lib/rocprof-sys/library/components/pthread_gotcha.cpp
71.4% 10/14 1/2 source/lib/core/containers/aligned_static_vector.hpp
71.7% 390/544 46/90 source/lib/rocprof-sys-dl/dl.cpp
72.2% 26/36 8/10 source/lib/rocprof-sys/regions.cpp
72.7% 24/33 5/7 source/lib/rocprof-sys/library/causal/components/causal_gotcha.cpp
72.7% 32/44 5/8 source/lib/rocprof-sys/library/causal/components/unblocking_gotcha.cpp
73.0% 54/74 12/14 source/lib/core/state.cpp
73.9% 407/551 30/33 source/lib/rocprof-sys/library/causal/data.cpp
74.5% 35/47 4/6 source/lib/rocprof-sys/library/pmc/collectors/cpu/cpu_traits.hpp
74.8% 440/588 31/42 source/bin/rocprof-sys-instrument/details.cpp
74.8% 223/298 15/16 source/bin/common/preset_registry.cpp
74.9% 1178/1572 52/88 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.cpp
75.0% 3/4 0/1 source/lib/backends/amd_smi/nic_types.hpp
75.0% 18/24 4/5 source/lib/rocprof-sys/library/causal/sample_data.cpp
75.4% 395/524 30/40 source/bin/common/json_config.cpp
76.2% 48/63 5/6 source/bin/rocprof-sys-instrument/log.cpp
76.5% 284/371 28/30 source/bin/common/common_utils.cpp
76.8% 53/69 5/6 source/lib/binary/link_map.cpp
77.3% 17/22 3/3 source/lib/common/static_object.hpp
77.8% 7/9 4/6 source/lib/core/constraint.hpp
77.9% 484/621 27/36 source/lib/rocprof-sys/library.cpp
78.1% 210/269 23/25 source/lib/rocprof-sys/library/causal/sampling.cpp
78.8% 204/259 25/29 source/bin/common/tool_runner.cpp
79.0% 132/167 12/12 source/bin/rocprof-sys-instrument/rocprof-sys-instrument.hpp
79.2% 19/24 2/2 source/lib/core/node_info.cpp
🟢 80-100% (145 files)
Lines Functions File
80.0% 4/5 0/1 source/bin/rocprof-sys-instrument/log.hpp
80.1% 209/261 20/22 source/bin/rocprof-sys-instrument/internal_libs.cpp
80.3% 61/76 8/9 source/lib/rocprof-sys/library/pmc/device_providers/rocprofiler_sdk/provider.hpp
81.2% 69/85 17/22 source/lib/rocprof-sys/library/causal/components/progress_point.cpp
81.2% 13/16 1/1 source/lib/rocprof-sys-dl/main.c
81.6% 1394/1708 265/289 source/lib/core/config.cpp
81.7% 432/529 40/40 source/bin/rocprof-sys-instrument/module_function.cpp
81.8% 121/148 22/25 source/lib/rocprof-sys/library/thread_info.cpp
82.3% 190/231 23/26 source/bin/rocprof-sys-avail/common.cpp
84.2% 16/19 3/5 source/lib/rocprof-sys/library/components/comm_data.hpp
84.3% 86/102 8/9 source/lib/binary/dwarf_entry.cpp
84.6% 11/13 2/4 source/lib/rocprof-sys/library/rocprofiler-sdk/roctx_client.hpp
84.9% 135/159 17/18 source/lib/binary/symbol.cpp
85.0% 317/373 18/29 source/lib/rocprof-sys/library/causal/experiment.cpp
85.1% 74/87 14/16 source/lib/rocprof-sys/library/causal/delay.cpp
85.2% 52/61 8/9 source/lib/core/utility.hpp
85.3% 87/102 10/10 source/lib/core/trace_cache/post_processor.cpp
85.7% 96/112 9/11 source/lib/rocprof-sys/library/process_sampler.cpp
85.9% 85/99 11/15 source/lib/logger/logger.hpp
86.0% 80/93 5/7 source/bin/rocprof-sys-instrument/module_function.hpp
86.1% 118/137 14/15 source/lib/common/path.hpp
86.3% 63/73 11/11 source/lib/core/rocpd/data_storage/database.cpp
87.0% 20/23 4/5 source/lib/core/containers/static_vector.hpp
87.0% 67/77 5/5 source/lib/core/trace_cache/discovery.cpp
87.5% 42/48 4/5 source/lib/core/output_file_registry.cpp
87.6% 141/161 13/16 source/lib/backends/procfs/backend.hpp
87.6% 283/323 16/20 source/lib/rocprof-sys/library/components/pthread_create_gotcha.cpp
88.1% 104/118 12/13 source/lib/rocprof-sys/library/tracing.cpp
88.2% 388/440 35/47 source/bin/rocprof-sys-causal/impl.cpp
88.6% 39/44 4/4 source/lib/core/utility.cpp
88.7% 268/302 28/32 source/lib/common/environment.hpp
89.0% 129/145 10/10 source/lib/rocprof-sys/library/coverage.cpp
89.1% 49/55 4/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/device.hpp
89.3% 25/28 4/4 source/lib/common/join.hpp
89.3% 767/859 59/74 source/lib/core/argparse.cpp
89.6% 147/164 9/14 source/lib/common/md5sum.hpp
90.0% 18/20 5/5 source/bin/rocprof-sys-instrument/function_signature.hpp
90.0% 9/10 1/1 source/lib/binary/scope_filter.cpp
90.0% 9/10 3/3 source/lib/common/synchronized.hpp
90.0% 54/60 4/4 source/lib/core/trace_cache/buffer_storage.cpp
90.0% 36/40 3/3 source/lib/core/trace_cache/cache_manager.cpp
90.0% 9/10 1/1 source/lib/rocprof-sys/library/thread_deleter.cpp
90.1% 64/71 9/11 source/lib/rocprof-sys/library/components/backtrace.cpp
90.6% 106/117 5/5 source/lib/binary/analysis.cpp
90.7% 303/334 28/31 source/lib/core/trace_cache/sample_type.hpp
91.0% 243/267 19/20 source/lib/core/trace_cache/unified_memory_processor.cpp
91.0% 132/145 29/31 source/lib/rocprof-sys/library/thread_data.hpp
91.3% 178/195 14/18 source/lib/rocprof-sys/library/components/shmem_gotcha.hpp
91.4% 85/93 6/7 source/bin/rocprof-sys-instrument/function_signature.cpp
91.4% 235/257 11/12 source/bin/rocprof-sys-avail/generate_config.cpp
91.9% 102/111 8/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/device.hpp
92.3% 156/169 8/8 source/lib/rocprof-sys/library/pmc/collectors/gpu/device.hpp
92.7% 863/931 40/47 source/bin/rocprof-sys-avail/avail.cpp
92.9% 26/28 3/4 source/lib/core/rocpd/data_storage/insert_query_builders.hpp
92.9% 13/14 0/1 source/lib/rocprof-sys/library/pmc/collectors/common/collector_slice.hpp
92.9% 13/14 2/2 source/lib/rocprof-sys/library/pmc/device_providers/procfs/provider.hpp
93.0% 66/71 7/8 source/lib/core/trace_cache/buffer_storage.hpp
93.1% 27/29 3/5 source/lib/rocprof-sys/library/coverage.hpp
93.8% 30/32 6/6 source/lib/core/mpi.hpp
94.1% 239/254 29/33 source/lib/rocprof-sys/library/components/category_region.hpp
94.1% 16/17 3/3 source/bin/rocprof-sys-avail/component_categories.hpp
94.8% 55/58 1/5 source/lib/core/trace_cache/cacheable.hpp
95.0% 19/20 2/2 source/lib/common/setup.hpp
95.1% 58/61 7/8 source/lib/rocprof-sys/library/pmc/collectors/cpu/sample.hpp
95.7% 45/47 2/2 source/lib/core/trace_cache/storage_parser.hpp
95.8% 23/24 1/2 source/lib/common/delimit.hpp
95.9% 162/169 19/22 source/lib/rocprof-sys/library/components/ucx_gotcha.hpp
96.1% 74/77 6/6 source/lib/rocprof-sys/library/causal/components/backtrace.cpp
96.8% 30/31 3/4 source/lib/rocprof-sys/library/pmc/collectors/gpu_perf_counter/sample.hpp
96.9% 94/97 10/10 source/lib/rocprof-sys/library/rocprofiler-sdk/trace_control.cpp
97.3% 73/75 6/6 source/lib/core/common_types.hpp
97.8% 45/46 10/12 source/lib/core/containers/stable_vector.hpp
97.8% 45/46 7/7 source/lib/rocprof-sys/library/rocprofiler-sdk/rccl_internal.hpp
97.9% 47/48 3/3 source/lib/rocprof-sys/library/pmc/collectors/nic/device.hpp
98.1% 51/52 7/7 source/lib/rocprof-sys/library/pmc/device_providers/amd_smi/provider.hpp
98.2% 56/57 6/8 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha.hpp
98.4% 63/64 14/14 source/lib/core/trace_cache/data_types.cpp
98.6% 73/74 14/15 source/lib/backends/amd_smi/backend.hpp
100.0% 36/36 4/5 source/bin/common/common_utils.hpp
100.0% 1/1 0/1 source/bin/common/json_config.hpp
100.0% 61/61 6/6 source/bin/rocprof-sys-avail/avail.hpp
100.0% 39/39 2/2 source/bin/rocprof-sys-avail/get_availability.hpp
100.0% 10/10 1/1 source/bin/rocprof-sys-avail/get_categories.hpp
100.0% 4/4 1/1 source/bin/rocprof-sys-avail/info_type.cpp
100.0% 9/9 0/1 source/bin/rocprof-sys-avail/info_type.hpp
100.0% 2/2 1/1 source/bin/rocprof-sys-run/rocprof-sys-run.cpp
100.0% 2/2 1/1 source/bin/rocprof-sys-sample/rocprof-sys-sample.cpp
100.0% 105/105 13/14 source/lib/backends/amd_smi/device.hpp
100.0% 7/7 0/1 source/lib/backends/amd_smi/gpu_types.hpp
100.0% 1/1 0/1 source/lib/backends/rocprofiler_sdk/types.hpp
100.0% 9/9 0/1 source/lib/binary/address_multirange.hpp
100.0% 7/7 1/1 source/lib/binary/binary_info.hpp
100.0% 1/1 0/1 source/lib/binary/dwarf_entry.hpp
100.0% 3/3 0/1 source/lib/binary/link_map.hpp
100.0% 5/5 1/2 source/lib/binary/scope_filter.hpp
100.0% 8/8 7/8 source/lib/binary/symbol.hpp
100.0% 9/9 2/2 source/lib/common/env_vars.hpp
100.0% 3/3 0/1 source/lib/common/span.hpp
100.0% 3/3 1/1 source/lib/common/units.hpp
100.0% 2/2 1/2 source/lib/core/agent_manager.hpp
100.0% 5/5 0/2 source/lib/core/argparse.hpp
100.0% 9/9 1/3 source/lib/core/binary/address_range.hpp
100.0% 49/49 10/10 source/lib/core/categories.cpp
100.0% 11/11 11/11 source/lib/core/components/fwd.hpp
100.0% 26/26 3/3 source/lib/core/config.hpp
100.0% 11/11 1/3 source/lib/core/containers/c_array.hpp
100.0% 1/1 0/1 source/lib/core/containers/operators.hpp
100.0% 41/41 7/11 source/lib/core/demangler.hpp
100.0% 2/2 2/2 source/lib/core/node_info.hpp
100.0% 1/1 0/1 source/lib/core/output_file_registry.hpp
100.0% 1/1 0/1 source/lib/core/progress/bar.hpp
100.0% 6/6 2/2 source/lib/core/progress/tracker.cpp
100.0% 1/1 0/1 source/lib/core/progress/tracker.hpp
100.0% 7/7 1/2 source/lib/core/rocpd/data_storage/table_insert_query.hpp
100.0% 2/2 0/1 source/lib/core/state.hpp
100.0% 7/7 1/3 source/lib/core/trace_cache/cache_manager.hpp
100.0% 4/4 0/3 source/lib/core/trace_cache/data_types.hpp
100.0% 9/9 3/3 source/lib/core/trace_cache/type_registry.hpp
100.0% 24/24 4/5 source/lib/core/trace_cache/unified_memory_processor.hpp
100.0% 10/10 1/1 source/lib/logger/logger.cpp
100.0% 7/7 1/2 source/lib/rocprof-sys/library/causal/components/backtrace.hpp
100.0% 23/23 2/3 source/lib/rocprof-sys/library/causal/components/progress_point.hpp
100.0% 3/3 1/2 source/lib/rocprof-sys/library/causal/experiment.hpp
100.0% 4/4 1/1 source/lib/rocprof-sys/library/causal/selected_entry.cpp
100.0% 5/5 2/3 source/lib/rocprof-sys/library/causal/selected_entry.hpp
100.0% 1/1 1/1 source/lib/rocprof-sys/library/components/backtrace.hpp
100.0% 11/11 1/2 source/lib/rocprof-sys/library/components/backtrace_metrics.hpp
100.0% 4/4 0/2 source/lib/rocprof-sys/library/components/backtrace_timestamp.hpp
100.0% 1/1 1/1 source/lib/rocprof-sys/library/components/callchain.hpp
100.0% 8/8 2/2 source/lib/rocprof-sys/library/components/ensure_storage.hpp
100.0% 1/1 0/1 source/lib/rocprof-sys/library/components/fork_gotcha.hpp
100.0% 2/2 0/1 source/lib/rocprof-sys/library/components/mpi_gotcha.hpp
100.0% 533/533 12/12 source/lib/rocprof-sys/library/components/mpip.hpp
100.0% 3/3 0/1 source/lib/rocprof-sys/library/components/pthread_create_gotcha.hpp
100.0% 23/23 1/2 source/lib/rocprof-sys/library/components/pthread_mutex_gotcha_policy.hpp
100.0% 11/11 0/3 source/lib/rocprof-sys/library/perf.hpp
100.0% 66/66 5/5 source/lib/rocprof-sys/library/pmc/collectors/cpu/cache_policy.hpp
100.0% 3/3 0/2 source/lib/rocprof-sys/library/pmc/collectors/cpu/types.hpp
100.0% 9/9 0/2 source/lib/rocprof-sys/library/pmc/collectors/gpu/types.hpp
100.0% 2/2 0/1 source/lib/rocprof-sys/library/pmc/common/types.hpp
100.0% 34/34 3/4 source/lib/rocprof-sys/library/rocprofiler-sdk/marker_writer.hpp
100.0% 3/3 1/2 source/lib/rocprof-sys/library/rocprofiler-sdk/trace_control.hpp
100.0% 2/2 0/1 source/lib/rocprof-sys/library/runtime.hpp
100.0% 10/10 3/3 source/lib/rocprof-sys/library/thread_data_growth.hpp
100.0% 5/5 1/1 source/lib/rocprof-sys/library/thread_deleter.hpp

Distribution

Range Files
0-20% 46
20-50% 20
50-80% 55
80-100% 145

@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch 2 times, most recently from f29520a to bc56e4f Compare June 16, 2026 22:17
@estewart08
estewart08 marked this pull request as draft June 16, 2026 22:31
@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch 3 times, most recently from a5e9d9e to ae45796 Compare June 17, 2026 20:33
@estewart08
estewart08 marked this pull request as ready for review June 18, 2026 04:51
@estewart08

estewart08 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

This change should probably also be added to the following:

Addressed your comments, looks like all checks passed.

@kcossett-amd

kcossett-amd commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Addressed your comments, looks like all checks passed.

Thank you, let me pull in copilot per our standard procedures and I'll give this a closer look as an initial review.

@kcossett-amd
kcossett-amd requested a review from Copilot June 18, 2026 12:14
Copilot AI reviewed Jun 18, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates rocprofiler-systems’ libomptarget discovery to support LLVM installations that use per-target runtime directories (e.g., when LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON), where libomptarget.so can live under .../lib/llvm/lib/<host-triple>/.

Changes:

  • Add host-target-triple-based candidate paths for locating libomptarget.so in both runtime code and test configuration.
  • Generate and expose an LLVM_HOST_TRIPLE value via CMake into a compile-time define used by runtime discovery.
  • Update the OpenMP target example to search libomptarget using PATH_SUFFIXES ${LLVM_HOST_TRIPLE}.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
projects/rocprofiler-systems/tests/pytest/rocprofsys/config.py Adds ROCm LLVM lib path candidate under lib/llvm/lib/<triple> for test runtime env setup.
projects/rocprofiler-systems/source/lib/common/environment.hpp Extends runtime libomptarget search to include .../lib/llvm/lib/<triple> candidates.
projects/rocprofiler-systems/source/lib/common/defines.h.in Introduces ROCPROFSYS_ROCM_LLVM_HOST_TRIPLE define populated from CMake.
projects/rocprofiler-systems/source/lib/common/CMakeLists.txt Queries amdclang for target triple to feed defines.h configuration.
projects/rocprofiler-systems/examples/openmp/target/CMakeLists.txt Updates find_library(libomptarget) to search under <triple> subdirectory via PATH_SUFFIXES.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread projects/rocprofiler-systems/tests/pytest/rocprofsys/config.py Resolved
Comment thread projects/rocprofiler-systems/source/lib/common/CMakeLists.txt Resolved
Comment thread projects/rocprofiler-systems/source/lib/common/environment.hpp Resolved
Comment thread projects/rocprofiler-systems/examples/openmp/target/CMakeLists.txt Resolved
@estewart08

estewart08 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Any update on this? I ran this with ROCm/TheRock#5758 (LLVM_ENABLE_PER_TARGET_RUNTIMED_DIR) through CI and it looks good, besides the known timeouts and windows problems. https://github.com/ROCm/TheRock/actions/runs/27832139093

@sputhala-amd sputhala-amd mentioned this pull request Jun 22, 2026
Closed
@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch from ae45796 to ebb4a0b Compare June 22, 2026 16:57
sputhala-amd
sputhala-amd reviewed Jun 23, 2026
View reviewed changes
Comment thread projects/rocprofiler-systems/examples/openmp/target/CMakeLists.txt Resolved
Comment thread projects/rocprofiler-systems/source/lib/common/defines.h.in Resolved
Comment thread projects/rocprofiler-systems/source/lib/common/environment.hpp Resolved
@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch 3 times, most recently from 84a6835 to 2d690ae Compare June 26, 2026 21:42
@therock-pr-bot

therock-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ❌ Fail Branch name does not match allowed patterns.
Branch: amd/dev/estewart/rocprofiler-systems-libomptarget-search
Allowed patterns:
- ^users\/[A-Za-z0-9][A-Za-z0-9\-]*\/.+
- ^shared\/.+
- ^[A-Za-z0-9][A-Za-z0-9\-_]*$
- ^dependabot\/.+
- ^revert-[0-9]+-.+
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
───
Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ❌ Fail Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-systems/source/lib/common/environment.hpp, projects/rocprofiler-systems/tests/pytest/rocprofsys/config.py; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 3 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ Branch Name
  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jun 26, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ Branch Name
  • ❌ PR Title/Description
  • ❌ Unit Test

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch 2 times, most recently from 146fd23 to 25fc764 Compare July 6, 2026 20:12
estewart08 added 11 commits July 7, 2026 09:10
@estewart08
[rocprofiler-systems] - add suffix to libomptarget find_library
74ee081 
This is in prepartion for compiler using LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON
by default. This option will install libomptarget.so in a target specific
directory one level down in lib. Then the path would be:
INSTALL_PREFIX/lib/llvm/lib/x86_64-unknown-linux-gnu.

This is required for ROCm/TheRock#5758
@estewart08
[rocprofiler-systems] - Add llvm host triple to pytest config.py
d71d284
@estewart08
[rocprofiler-systems] - Add ROCPROFSYS_ROCM_LLVM_HOST_TRIPLE usage to…
9f72ebe 
… common headers
@estewart08
[rocprofiler-systems] - Format line break in environment.hpp
fa4a7e2
@estewart08
[rocprofiler-systems] - Address PR comments
ade19df 
- Move host_triple inside of clang path check.
- Use find_program to locate amdclang. If LLVM_HOST_TRIPLE is empty a warning is reurned.
@estewart08
[rocprofiler-systems] - guard llvm_host_triple path usage in environm…
bf126de 
…ent.hpp

If triple is empty do not push the path to the candidates.
Increase candidates reserve to 8 (includes 2 new host triple paths).
@estewart08
[rocprofiler-systems] - python formatting in config.py
d21d2ba
@estewart08
[rocprofiler-systems] - format spaces in in environment.hpp
b39cf5f
@estewart08
[rocprofiler-systems] - Add result variable to --print-target-triple
a120d98 
Keep error quiet and set LLVM_HOST_TRIPLE to empty.
@estewart08
[rocprofiler-systems] - Address comments in PR
013ced7 
- Ensured if the clang target triple query fails that cmake throws
a fatal error.
- Added try/execpt for target triple querey in config.py.
- Removed duplicate paths in find_program(amdclang)
@estewart08
[rocprofiler-tests] - Update get_llvm_lib_paths to cached_property
68819c9 
- Renamed get_llvm_lib_paths to llvm_lib_paths
- The triple returned from clang will be static and set at build time.
- Moving the clang binary to a new system will not change the value.
@estewart08
estewart08 force-pushed the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch from 25fc764 to 68819c9 Compare July 7, 2026 14:11
@estewart08

estewart08 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Another unrelated error:
test-pc-sampling-collector .......................***Failed 0.00 sec /__w/rocm-systems/rocm-systems/build/libexec/rocprofiler-compute/tests/test-pc-sampling-collector: error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file: No such file or directory.

Any knowledge on this?

@estewart08

estewart08 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Another unrelated error: test-pc-sampling-collector .......................***Failed 0.00 sec /__w/rocm-systems/rocm-systems/build/libexec/rocprofiler-compute/tests/test-pc-sampling-collector: error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file: No such file or directory.

Any knowledge on this?

Supposedly, this was fixed with ROCm/TheRock#6386.

@estewart08

estewart08 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Looks like CI finally passed. Can I get a final approval?

sputhala-amd
sputhala-amd approved these changes Jul 9, 2026
View reviewed changes

@sputhala-amd sputhala-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @estewart08.

@estewart08
estewart08 merged commit fc83dd1 into develop Jul 9, 2026
80 of 81 checks passed
@estewart08
estewart08 deleted the amd/dev/estewart/rocprofiler-systems-libomptarget-search branch July 9, 2026 07:03
estewart08 added a commit to ROCm/TheRock that referenced this pull request Jul 13, 2026
@estewart08
[patches] - Remove rocm-systems patch
589fdb0 
This was applied directly to rocm-systems repo:
ROCm/rocm-systems#7334
estewart08 added a commit to ROCm/TheRock that referenced this pull request Jul 14, 2026
@estewart08
[patches] - Remove rocm-systems patch
45ed887 
This was applied directly to rocm-systems repo:
ROCm/rocm-systems#7334
estewart08 added a commit to ROCm/TheRock that referenced this pull request Jul 16, 2026
@estewart08
[patches] - Remove rocm-systems patch
fbe0c83 
This was applied directly to rocm-systems repo:
ROCm/rocm-systems#7334
estewart08 added a commit to ROCm/TheRock that referenced this pull request Jul 21, 2026
@estewart08
[patches] - Remove rocm-systems patch
f8dc607 
This was applied directly to rocm-systems repo:
ROCm/rocm-systems#7334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@sputhala-amd sputhala-amd sputhala-amd approved these changes
@jrmadsen jrmadsen Awaiting requested review from jrmadsen jrmadsen is a code owner
+1 more reviewer
@kcossett-amd kcossett-amd kcossett-amd left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

organization: ROCm project: rocprofiler-systems

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@estewart08 @kcossett-amd @sputhala-amd