Repository navigation
fix(rocprofiler-compute): set RPATH origin for pc-sampling test binary - #6386
Merged
vedithal-amd merged 1 commit intoJul 7, 2026
Merged
vedithal-amd merged 1 commit into
vedithal-amd merged 1 commit into
Conversation
- Extend the post-hook to set THEROCK_INSTALL_RPATH_ORIGIN on test-pc-sampling-collector, matching test-rocprofiler-compute-tool. - Both tests install to libexec/rocprofiler-compute/tests/, so TheRock can now compute correct relative RPATHs (including lib/rocm_sysdeps/lib) and resolve librocm_sysdeps_dw.so.1 at load time. Co-Authored-By: Claude Opus 4
1 of 3 tasks
vedithal-amd
changed the title
Contributor
Author
|
Fixes ROCm/rocm-systems#8186 |
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes runtime loading of the installed test-pc-sampling-collector binary by ensuring TheRock computes relative RPATH entries from the test’s actual install location (libexec/rocprofiler-compute/tests/) instead of the default executable origin (bin/). This aligns the pc-sampling test with the existing handling for test-rocprofiler-compute-tool, so sysdeps libraries under lib/rocm_sysdeps/lib can be found without relying on LD_LIBRARY_PATH.
Changes:
- Extend the rocprofiler-compute post-hook to apply
THEROCK_INSTALL_RPATH_ORIGIN=libexec/rocprofiler-compute/teststo bothtest-rocprofiler-compute-toolandtest-pc-sampling-collector. - Refactor the per-target logic into a small
foreach()loop with aTARGETexistence guard.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
therock-pr-bot
Bot
removed
the
Not ready to Review
vedithal-amd
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 7, 2026
- TheRock's post-process computes the authoritative RPATH for these test binaries (including lib/rocm_sysdeps/lib) relative to their install origin, overriding any local INSTALL_RPATH. The hardcoded blocks were no-ops under TheRock and omitted the sysdeps path. - Origin handling for both tests now lives in TheRock's post-hook (ROCm/TheRock#6386). Co-Authored-By: Claude Opus 4
marbre
approved these changes
Jul 7, 2026
cgoea
approved these changes
Jul 7, 2026
Contributor
Author
|
Since this is just a small change to rocprofiler-compute tool install hook - i am not waiting for windows and linux checks for compiler and runtime libs since those should not be affected by this |
vedithal-amd
deleted the
users/vedithal-amd/rocprofiler-compute-pc-sampling-test-rpath
branch
July 7, 2026 16:17
abchoudh-amd
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 9, 2026
…8191) ## Motivation Bugfix: `test-pc-sampling-collector` fails in CI with `error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file`. The hardcoded `INSTALL_RPATH` on the test targets does not fix this: TheRock's post-process overrides any local `INSTALL_RPATH`, and the hardcoded path omitted `lib/rocm_sysdeps/lib` where the missing library lives. ## Technical Details - Remove the redundant `INSTALL_RPATH` blocks from `pc_sampling_collector/tests/CMakeLists.txt` and `rocprofiler_compute_tool/tests/CMakeLists.txt`. - TheRock computes the authoritative RPATH (including sysdeps) for these test binaries relative to their install origin. Origin handling for both tests lives in TheRock's post-hook (paired PR ROCm/TheRock#6386). JIRA ID - AIPROFCOMP-710 ## Test Plan - [ ] Run CI ## Test Result - [ ] CI passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
davidd-amd
pushed a commit
that referenced
this pull request
Jul 9, 2026
#6386) ## Summary `test-pc-sampling-collector` fails at load with `error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file`. The unified test runner no longer adds sysdeps to `LD_LIBRARY_PATH`, so installed test binaries must resolve sysdeps via RPATH. This test installs to `libexec/rocprofiler-compute/tests/`, not the default `bin/`. Without a correct `THEROCK_INSTALL_RPATH_ORIGIN`, TheRock computes its sysdeps RPATH relative to `bin/`, so `librocm_sysdeps_dw.so.1` (in `lib/rocm_sysdeps/lib`) is not found. Extend the post-hook to set `THEROCK_INSTALL_RPATH_ORIGIN = libexec/rocprofiler-compute/tests` for `test-pc-sampling-collector`, mirroring the existing handling of `test-rocprofiler-compute-tool` (#5108). ISSUE ID: ROCm/rocm-systems#8186 ## Testing Summary - Verified against an existing build that `test-rocprofiler-compute-tool` RUNPATH already includes `$ORIGIN/../../../lib/rocm_sysdeps/lib` and `ldd` resolves `librocm_sysdeps_dw.so.1` cleanly; this applies the same origin to the pc-sampling test. - CI to confirm `test-pc-sampling-collector` loads and passes. Paired rocm-systems change (ROCm/rocm-systems#8191) removes the now-redundant hardcoded `INSTALL_RPATH` blocks from both test CMakeLists.
cfallows-amd
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 24, 2026
…8191) ## Motivation Bugfix: `test-pc-sampling-collector` fails in CI with `error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file`. The hardcoded `INSTALL_RPATH` on the test targets does not fix this: TheRock's post-process overrides any local `INSTALL_RPATH`, and the hardcoded path omitted `lib/rocm_sysdeps/lib` where the missing library lives. ## Technical Details - Remove the redundant `INSTALL_RPATH` blocks from `pc_sampling_collector/tests/CMakeLists.txt` and `rocprofiler_compute_tool/tests/CMakeLists.txt`. - TheRock computes the authoritative RPATH (including sysdeps) for these test binaries relative to their install origin. Origin handling for both tests lives in TheRock's post-hook (paired PR ROCm/TheRock#6386). JIRA ID - AIPROFCOMP-710 ## Test Plan - [ ] Run CI ## Test Result - [ ] CI passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
vedithal-amd
added a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 27, 2026
…8191) ## Motivation Bugfix: `test-pc-sampling-collector` fails in CI with `error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file`. The hardcoded `INSTALL_RPATH` on the test targets does not fix this: TheRock's post-process overrides any local `INSTALL_RPATH`, and the hardcoded path omitted `lib/rocm_sysdeps/lib` where the missing library lives. ## Technical Details - Remove the redundant `INSTALL_RPATH` blocks from `pc_sampling_collector/tests/CMakeLists.txt` and `rocprofiler_compute_tool/tests/CMakeLists.txt`. - TheRock computes the authoritative RPATH (including sysdeps) for these test binaries relative to their install origin. Origin handling for both tests lives in TheRock's post-hook (paired PR ROCm/TheRock#6386). JIRA ID - AIPROFCOMP-710 ## Test Plan - [ ] Run CI ## Test Result - [ ] CI passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
amd-josnarlo
pushed a commit
to ROCm/rocm-systems
that referenced
this pull request
Jul 28, 2026
…8191) ## Motivation Bugfix: `test-pc-sampling-collector` fails in CI with `error while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file`. The hardcoded `INSTALL_RPATH` on the test targets does not fix this: TheRock's post-process overrides any local `INSTALL_RPATH`, and the hardcoded path omitted `lib/rocm_sysdeps/lib` where the missing library lives. ## Technical Details - Remove the redundant `INSTALL_RPATH` blocks from `pc_sampling_collector/tests/CMakeLists.txt` and `rocprofiler_compute_tool/tests/CMakeLists.txt`. - TheRock computes the authoritative RPATH (including sysdeps) for these test binaries relative to their install origin. Origin handling for both tests lives in TheRock's post-hook (paired PR ROCm/TheRock#6386). JIRA ID - AIPROFCOMP-710 ## Test Plan - [ ] Run CI ## Test Result - [ ] CI passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test-pc-sampling-collectorfails at load witherror while loading shared libraries: librocm_sysdeps_dw.so.1: cannot open shared object file. The unified test runner no longer adds sysdeps toLD_LIBRARY_PATH, so installed test binaries must resolve sysdeps via RPATH.This test installs to
libexec/rocprofiler-compute/tests/, not the defaultbin/. Without a correctTHEROCK_INSTALL_RPATH_ORIGIN, TheRock computes its sysdeps RPATH relative tobin/, solibrocm_sysdeps_dw.so.1(inlib/rocm_sysdeps/lib) is not found.Extend the post-hook to set
THEROCK_INSTALL_RPATH_ORIGIN = libexec/rocprofiler-compute/testsfortest-pc-sampling-collector, mirroring the existing handling oftest-rocprofiler-compute-tool(#5108).ISSUE ID: ROCm/rocm-systems#8186
Testing Summary
test-rocprofiler-compute-toolRUNPATH already includes$ORIGIN/../../../lib/rocm_sysdeps/libandlddresolveslibrocm_sysdeps_dw.so.1cleanly; this applies the same origin to the pc-sampling test.test-pc-sampling-collectorloads and passes.Paired rocm-systems change (ROCm/rocm-systems#8191) removes the now-redundant hardcoded
INSTALL_RPATHblocks from both test CMakeLists.