Repository navigation
[rocprofiler-sdk] Enable rocpd multiproc rocprofv3 ctests - #6934
Closed
minseobshin11 wants to merge 1 commit into
Closed
minseobshin11 wants to merge 1 commit into
minseobshin11 wants to merge 1 commit into
Conversation
minseobshin11
force-pushed
the
users/mishin/enable-rocpd-tests-ci
branch
from
June 8, 2026 20:16
fff1797 to
02fabdc
Compare
minseobshin11
force-pushed
the
users/mishin/enable-rocpd-tests-ci
branch
from
June 8, 2026 20:49
02fabdc to
9ef01e5
Compare
Contributor
|
Just saw this. I have equivalent PR #4927 that I've been trying to get merged too. Would you be kind enough to give a 1st review? |
minseobshin11
force-pushed
the
users/mishin/enable-rocpd-tests-ci
branch
from
June 10, 2026 15:30
9ef01e5 to
2045ac9
Compare
Contributor
|
As mentioned. This is superseded by #4927 and this draft PR can probably be closed. |
Contributor
Author
Hi thanks for the heads up! I agree #4927 covers everything here. I'll close this draft in favor of your PR. I can also first review your PR if needed (I'm an intern), but I have let my team know of your PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The 8
rocprofv3-test-rocpd-*-multiproctests were disabled due to instability. The instability was caused by test-harnessmisconfiguration, not by the feature under test. This PR fixes the root causes and re-enables the tests so RocPD multi-process profiling is actually covered in CI.
Technical Details
Changes in
projects/rocprofiler-sdk/tests/rocprofv3/rocpd/CMakeLists.txt:ROCPROFILER_DISABLE_UNSTABLE_CTESTSguard that unconditionally disabled the multiproc tests.ENVIRONMENT(MPI varsOMPI_ALLOW_RUN_AS_ROOT*+PYTHONPATH) to thempiexec-launched test so OpenMPI can run under root and resolve therocprofv3Python module.otf2/perfetto/summarygeneration-multiprocconverter tests to the multiproc fixture (was the single-proc fixture), fixing a race that produced missing input DBs under parallel ctest.JIRA ID
Resolves AIROCVAL-46
Test Plan
Tests are MPI-gated (
find_package(MPI)); when MPI is absent they are skipped. They will activate automatically once OpenMPI is provisioned in the CI image (tracked separately in #6671). Verified locally with MPI present: all 8 multiproc tests pass, serial and parallel.mpiexecreproduction.Test Result
Submission Checklist