Skip to content

tests(rocprofiler-SDK): [rocpd] Re-enable rocpd MPI tests - #4927

Merged
amd-hsivasun merged 9 commits into
developfrom
users/yhui/rocpd-fix-disabled-multiproc-tests
Sep 30, 2026
Merged

tests(rocprofiler-SDK): [rocpd] Re-enable rocpd MPI tests#4927
amd-hsivasun merged 9 commits into
developfrom
users/yhui/rocpd-fix-disabled-multiproc-tests

Conversation

@yhuiYH

@yhuiYH yhuiYH commented Apr 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Motivation

rocpd MPI tests were disabled due to failing on SLES CI on MI300 before. Re-enable these tests now to see if they are passing on mi325.

Technical Details

Re-enable disabled MPI tests

JIRA ID

JIRA ID: AIROCVAL-46

Test Plan

You can run ctest -R rocpd and confirm all the multiproc tests are no longer disabled, and they run successfully.

Test Result

The -multiproc tests are now running (no longer disabled) on the CI as well. On Ubuntu, SLES, RHEL 8.8 and 9.5

Submission Checklist

@yhuiYH yhuiYH changed the title [rocprofiler-SDK] [rocpd] Re-enable disabled rocpd MPI tests [rocprofiler-SDK] [rocpd] Re-enable rocpd MPI tests Apr 10, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch 2 times, most recently from 83512de to f594d75 Compare April 18, 2026 00:54
@github-actions

github-actions Bot commented Apr 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@yhuiYH

yhuiYH commented Apr 20, 2026

Copy link
Copy Markdown
Contributor Author

RHEL tests now passing after merging #5097 to include openmpi-devel package to RHEL CI docker images

@yhuiYH
yhuiYH marked this pull request as ready for review April 21, 2026 00:03
@yhuiYH
yhuiYH requested review from a team as code owners April 21, 2026 00:03
Copilot AI review requested due to automatic review settings April 21, 2026 00:03
Copilot AI reviewed Apr 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Re-enables the rocpd MPI/multiprocess integration tests in the rocprofiler-SDK test suite so they run again in CI (to validate current stability on newer hardware/CI images).

Changes:

  • Stops force-disabling multiprocess tests under ROCPROFILER_DISABLE_UNSTABLE_CTESTS.
  • Adds the rocprofv3-rocpd-env environment to the multiprocess execute test.
  • Updates multiprocess fixture setup/requirements for OTF2/Perfetto/Summary generation tests and removes the extra single-proc “execute2” test.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread projects/rocprofiler-sdk/tests/rocprofv3/rocpd/CMakeLists.txt Resolved
@yhuiYH yhuiYH added the rocpd label May 11, 2026
@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Jun 6, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 9e46b75 to ba46e65 Compare June 8, 2026 14:41
@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Jun 9, 2026
@yhuiYH yhuiYH mentioned this pull request Jun 10, 2026
Closed
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from ba46e65 to 24a7889 Compare June 10, 2026 16:11
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 24a7889 to 1ca9ef4 Compare July 6, 2026 21:22
@therock-pr-bot

therock-pr-bot Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@yhuiYH yhuiYH changed the title [rocprofiler-SDK] [rocpd] Re-enable rocpd MPI tests tests(rocprofiler-SDK): [rocpd] Re-enable rocpd MPI tests Jul 27, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 1ca9ef4 to 854997d Compare July 29, 2026 21:25
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Aug 24, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 854997d to 291de30 Compare August 24, 2026 18:17
@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Aug 25, 2026
@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Sep 19, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 291de30 to 8ca5f71 Compare September 21, 2026 14:22
@github-actions github-actions Bot removed the Stale PR has no activity for 25+ days label Sep 22, 2026
@yhuiYH
yhuiYH force-pushed the users/yhui/rocpd-fix-disabled-multiproc-tests branch from 81e7fbb to 02ee708 Compare September 24, 2026 17:58
@amd-hsivasun
amd-hsivasun merged commit d2c0b1e into develop Sep 30, 2026
268 of 276 checks passed
@amd-hsivasun
amd-hsivasun deleted the users/yhui/rocpd-fix-disabled-multiproc-tests branch September 30, 2026 15:33
@systems-assistant

systems-assistant Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@bgopesh bgopesh bgopesh approved these changes
@mcao59 mcao59 mcao59 approved these changes

Assignees

No one assigned

Labels

organization: ROCm project: rocprofiler-sdk ready for 2nd review rocpd rocprofiler-sdk: Ready for 2nd code review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yhuiYH @bgopesh @mcao59 @amd-hsivasun