Skip to content

[rocjitsu] Close the divergence between generator changes and generated isa files - #6885

Closed
kuhar wants to merge 2 commits into
developfrom
users/kuhar/gfx1250-isa
Closed

kuhar wants to merge 2 commits into
developfrom
users/kuhar/gfx1250-isa

Conversation

@kuhar

@kuhar kuhar commented Jun 6, 2026 •

Copy link
Copy Markdown
Member

Motivation

We incurred divergence between the generator script and the generated files checked into the repo. This PR closes this gap and makes sure that the generated state is functional and matches the generator script.

Technical Details

The divergence got introduced by #6673.

JIRA ID

N/A

Test Plan

Build all and run tests.

Test Result

Passes with both clang and gcc.

Submission Checklist

Copilot AI review requested due to automatic review settings June 6, 2026 12:05
@kuhar
kuhar requested a review from atgutier as a code owner June 6, 2026 12:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@kuhar

kuhar commented Jun 6, 2026

Copy link
Copy Markdown
Member Author

Superseded by #6886

@kuhar kuhar closed this Jun 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants