Skip to content

[TheRock CI] Update projects_to_test lists #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jayhawk-commits merged 14 commits into from
Mar 6, 2026
Merged

[TheRock CI] Update projects_to_test lists #3749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
03cd3f2
[TheRock CI] Update projects_to_test lists
jayhawk-commits Mar 4, 2026
4ba5601
Test against ROCm/TheRock##3768
jayhawk-commits Mar 4, 2026
08301b6
Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…
rahulc-gh Mar 5, 2026
ff54fa4
Revert "Test against ROCm/TheRock##3768"
jayhawk-commits Mar 5, 2026
02482ae
Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…
jayhawk-commits Mar 5, 2026
3022915
Add Setup Additional Requirements step for component Python deps
jayhawk-commits Mar 6, 2026
3c12cd4
Merge branch 'users/jayhawk-commits/projects_to_test_march4' of https…
jayhawk-commits Mar 6, 2026
1416156
Fixes for hip-tests and skip rocgdb tests for now
jayhawk-commits Mar 6, 2026
9d3926f
Forgot rocgdb occurrence
jayhawk-commits Mar 6, 2026
f40dc34
Update TheRock SHA to 20260306 commit
jayhawk-commits Mar 6, 2026
7a39ec6
Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…
jayhawk-commits Mar 6, 2026
a9d3b01
Fix spacing between ref and comment
jayhawk-commits Mar 6, 2026
4a7a0bf
Merge branch 'users/jayhawk-commits/projects_to_test_march4' of githu…
jayhawk-commits Mar 6, 2026
f204347
Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…
jayhawk-commits Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/scripts/therock_matrix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@
project_map = {
"core": {
"cmake_options": "-DTHEROCK_ENABLE_ALL=ON",
"projects_to_test": "hip-tests",
"projects_to_test": "hip-tests, rocrtst",
},
"profiler": {
"cmake_options": "-DTHEROCK_ENABLE_ALL=ON",
"projects_to_test": "rocprofiler-tests",
"projects_to_test": "aqlprofile, rocprofiler-compute, rocprofiler_systems",
Copy link
Copy Markdown
Collaborator

@jbonnell-amd jbonnell-amd Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like rocprofiler-compute has a dash -, whereas rocprofiler_systems has an underscore _.

Copy link
Copy Markdown
Collaborator

@rahulc-gh rahulc-gh Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but that is how it is in - https://github.com/ROCm/TheRock/blob/main/build_tools/github_actions/fetch_test_configurations.py

Copy link
Copy Markdown
Collaborator

@jbonnell-amd jbonnell-amd Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, there was inconsistency between rocprofiler-compute and rocprofiler-systems with these definitions. I created a PR to address this; we can fix this in a later PR: ROCm/TheRock#3757

},
Comment thread
jayhawk-commits marked this conversation as resolved.
# media libs to be enabled in following PR
# "media-libs": {
Expand All @@ -44,15 +44,15 @@
# },
"dc_tools": {
"cmake_options": "-DTHEROCK_ENABLE_DC_TOOLS=ON -DTHEROCK_ENABLE_ALL=OFF",
"projects_to_test": "", # rdc-tests is not built by TheRock build system - TBD
"projects_to_test": "", # rdc-tests is not built by TheRock build system - TBD
},
"debug_tools": {
"cmake_options": "-DTHEROCK_ENABLE_DEBUG_TOOLS=ON -DTHEROCK_ENABLE_ALL=OFF",
"projects_to_test": "", # rocdbgapi-tests is not built by TheRock build system - TBD
"projects_to_test": "rocr-debug-agent", # rocgdb testing requires custom container support in rocm-systems, to be enabled in a future PR
},
"all": {
"cmake_options": "-DTHEROCK_ENABLE_ALL=ON",
Comment thread
jayhawk-commits marked this conversation as resolved.
"projects_to_test": "hip-tests, rocprofiler-tests",
"projects_to_test": "hip-tests, rocrtst, aqlprofile, rocprofiler-compute, rocprofiler_systems, rocr-debug-agent",
},
Comment thread
jayhawk-commits marked this conversation as resolved.
}

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/therock-ci-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
with:
repository: "ROCm/TheRock"
path: "TheRock"
ref: e45c216399d8384f831e66c8a5f7c9fbe7e739c1 # 2026-02-18 commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Install python deps
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/therock-ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
with:
repository: "ROCm/TheRock"
path: "TheRock"
ref: e45c216399d8384f831e66c8a5f7c9fbe7e739c1 # 2026-02-18 commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Set up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/therock-rccl-ci-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
with:
repository: "ROCm/TheRock"
path: "TheRock"
ref: 9a8534f5e38c8c5e20b1a92185aca578c2840a7d # 02-05-2026 Commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Install python deps
run: |
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/therock-rccl-test-packages-multi-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
type: string
artifact_run_id:
type: string

permissions:
contents: read
id-token: write
Expand All @@ -47,7 +47,7 @@ jobs:
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
repository: "ROCm/TheRock"
ref: 9a8534f5e38c8c5e20b1a92185aca578c2840a7d # 02-05-2026 Commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Run setup test environment workflow
uses: './.github/actions/setup_test_environment'
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/therock-test-component.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
repository: "ROCm/TheRock"
ref: 846614189049e22b02c85bf2b496a9025b27e75d # 2026-02-02 commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Run setup test environment workflow
uses: './.github/actions/setup_test_environment'
Expand All @@ -82,6 +82,12 @@ jobs:
run: |
python ./build_tools/print_driver_gpu_info.py

- name: Setup Additional Requirements
if: ${{ fromJSON(inputs.component).additional_requirements_files != '' }}
run: |
python ./build_tools/install_additional_requirements.py \
--requirements-files=${{ join(fromJSON(inputs.component).additional_requirements_files, ',') }}

Comment thread
jayhawk-commits marked this conversation as resolved.
- name: Test
timeout-minutes: ${{ fromJSON(inputs.component).timeout_minutes }}
env:
Expand All @@ -96,4 +102,4 @@ jobs:
- name: Post-job cleanup processes on Windows
if: ${{ always() && runner.os == 'Windows' }}
shell: powershell
run: . '${{ github.workspace }}\build_tools\github_actions\cleanup_processes.ps1'
run: . '${{ github.workspace }}\build_tools\github_actions\cleanup_processes.ps1'
6 changes: 3 additions & 3 deletions .github/workflows/therock-test-packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
sparse-checkout: build_tools
path: "prejob"
repository: "ROCm/TheRock"
ref: e45c216399d8384f831e66c8a5f7c9fbe7e739c1 # 2026-02-18 commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

# Checkout failure is possible on Windows, as it's the first job on a GPU test runner.
# Post-job cleanup isn't necessary since no executables are launched in this job.
Expand All @@ -42,7 +42,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
repository: "ROCm/TheRock"
ref: e45c216399d8384f831e66c8a5f7c9fbe7e739c1 # 2026-02-18 commit
ref: ad524887d223cbd04d6b423691958fe86b589944 # 2026-03-06 commit

- name: Setting up Python
uses: actions/setup-python@e797f83bcb11b83ae66e0230d6156d7c80228e7c # v6.0.0
Expand Down Expand Up @@ -71,4 +71,4 @@ jobs:
amdgpu_families: ${{ inputs.amdgpu_families }}
test_runs_on: ${{ inputs.test_runs_on }}
platform: ${{ inputs.platform }}
component: ${{ toJSON(matrix.components) }}
component: ${{ toJSON(matrix.components) }}
Loading