[TheRock CI] Update projects_to_test lists by jayhawk-commits · Pull Request #3749 · ROCm/rocm-systems

jayhawk-commits · 2026-03-04T18:32:22Z

Update TheRock SHA in workflows to a commit from 20260306.
Based on recent tests that were enabled on TheRock repo, updating the projects_to_test entries for hip-tests, rocrtst, aqlprofile, rocprofiler-compute, rocprofiler-systems, and rocr-debug-agent.
Changes correspond to entries in https://github.com/ROCm/TheRock/blob/main/build_tools/github_actions/fetch_test_configurations.py
rocgdb and sanity checks (for amdsmi and rocminfo) entries to be added in another PR.
See Deduplicate test_sanity_check.yml workflow TheRock#3823 and Custom test containers when using TheRock CI in rocm-systems #3847 for pending work,

- Based on recent tests that were enabled on TheRock repo, updating the `projects_to_test` entries for different projects.

jbonnell-amd · 2026-03-04T18:38:43Z

    "profiler": {
        "cmake_options": "-DTHEROCK_ENABLE_ALL=ON",
-        "projects_to_test": "rocprofiler-tests",
+        "projects_to_test": "aqlprofile, rocprofiler-compute, rocprofiler_systems",


Looks like rocprofiler-compute has a dash -, whereas rocprofiler_systems has an underscore _.

but that is how it is in - https://github.com/ROCm/TheRock/blob/main/build_tools/github_actions/fetch_test_configurations.py

Yeah, there was inconsistency between rocprofiler-compute and rocprofiler-systems with these definitions. I created a PR to address this; we can fix this in a later PR: ROCm/TheRock#3757

jayhawk-commits · 2026-03-04T22:55:55Z

I think I need to wait for #3709

jayhawk-commits · 2026-03-04T23:56:24Z

Updating TheRock SHAs to test against ROCm/TheRock#3768

…rch4

geomin12

overall lgtm

github issues right now, but if CI passes, lgtm!

jbonnell-amd · 2026-03-05T21:01:21Z

I noticed that the rocprofiler_compute tests are failing due to missing Python requirements. We'll probably need to port over these changes from TheRock's test_component.yml script over to rocm-system's therock-test-component.yml equivalent to get these requirements installed.

https://github.com/ROCm/TheRock/blob/main/.github/workflows/test_component.yml#L134-L138

jayhawk-commits · 2026-03-05T22:38:37Z

The tests get launched with my PR's changes. I will remove the changes to TheRock SHAs in this PR, and will rely on #3709

This reverts commit 4ba5601.

…rch4

Made-with: Cursor

…://github.com/ROCm/rocm-systems into users/jayhawk-commits/projects_to_test_march4

jayhawk-commits · 2026-03-06T00:09:56Z

I noticed that the rocprofiler_compute tests are failing due to missing Python requirements. We'll probably need to port over these changes from TheRock's test_component.yml script over to rocm-system's therock-test-component.yml equivalent to get these requirements installed.

https://github.com/ROCm/TheRock/blob/main/.github/workflows/test_component.yml#L134-L138

Thanks for catching this. I have added the step to this repo.

jayhawk-commits · 2026-03-06T03:58:19Z

Test environment for hip-tests and rocgdb are in a bad state.

jayhawk-commits · 2026-03-06T04:52:28Z

Further changes are required to support the custom container for rocgdb testing, so that will be deferred to a separate PR. @lumachad

rocr-debug-agent testing looks OK in this PR.

lumachad · 2026-03-06T09:43:29Z

Further changes are required to support the custom container for rocgdb testing, so that will be deferred to a separate PR. @lumachad

rocr-debug-agent testing looks OK in this PR.

Nice! thanks. But I think the latest run failed to find the testing scripts for some reason. On rocgdb testing being deferred to another PR, that's fine. Please ping me on the PR and I can keep an eye out for it.

jayhawk-commits · 2026-03-06T15:23:07Z

Further changes are required to support the custom container for rocgdb testing, so that will be deferred to a separate PR. @lumachad
rocr-debug-agent testing looks OK in this PR.

Nice! thanks. But I think the latest run failed to find the testing scripts for some reason. On rocgdb testing being deferred to another PR, that's fine. Please ping me on the PR and I can keep an eye out for it.

Was fine in this run https://github.com/ROCm/rocm-systems/actions/runs/22729017651/job/65931062366 where it was a different SHA of TheRock.

…rch4

…b.com:ROCm/rocm-systems into users/jayhawk-commits/projects_to_test_march4

lumachad · 2026-03-06T16:50:08Z

Further changes are required to support the custom container for rocgdb testing, so that will be deferred to a separate PR. @lumachad
rocr-debug-agent testing looks OK in this PR.

Nice! thanks. But I think the latest run failed to find the testing scripts for some reason. On rocgdb testing being deferred to another PR, that's fine. Please ping me on the PR and I can keep an eye out for it.

Was fine in this run https://github.com/ROCm/rocm-systems/actions/runs/22729017651/job/65931062366 where it was a different SHA of TheRock.

So it was. Looks like we're failing to checkout a particular TheRock revision. From looking at the rocgdb testing failure, your assessment that we're missing using the proper rocgdb norocm image is correct. I expect things will run correctly once we use the right container image.

…rch4

jayhawk-commits · 2026-03-06T21:20:08Z

For rocminfo and amd-smi coverage, we need to add the sanity check that TheRock does. We can do that in another PR. See ROCm/TheRock#3823.

jayhawk-commits · 2026-03-06T21:56:31Z

Created #3847 for rocgdb gap.

jayhawk-commits · 2026-03-06T21:57:14Z

TheRock CI passed before I changed it from draft mode.
See https://github.com/ROCm/rocm-systems/actions/runs/22776829238
Canceled the new CI run from post-draft to save resources.

Copilot

Pull request overview

Updates TheRock-based CI workflows to use a newer TheRock commit SHA (2026-03-06) and refreshes the per-component projects_to_test lists so the generated test matrix aligns with current TheRock test configurations.

Changes:

Bump TheRock checkout refs across multiple workflows to ad524887d223cbd04d6b423691958fe86b589944.
Update .github/scripts/therock_matrix.py projects_to_test mappings (core/profiler/debug/all).
Add a workflow step to install “additional requirements” before running component tests.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
.github/workflows/therock-test-packages.yml	Updates TheRock ref used to generate the test matrix and run package tests.
.github/workflows/therock-test-component.yml	Updates TheRock ref and adds a step to install component-specific extra requirements.
.github/workflows/therock-rccl-test-packages-multi-node.yml	Updates TheRock ref used for multi-node RCCL tests (plus whitespace cleanup).
.github/workflows/therock-rccl-ci-linux.yml	Updates TheRock ref used by RCCL CI on Linux.
.github/workflows/therock-ci-windows.yml	Updates TheRock ref used by Windows CI.
.github/workflows/therock-ci-linux.yml	Updates TheRock ref used by Linux CI.
.github/scripts/therock_matrix.py	Refreshes which tests to run per logical project grouping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[TheRock CI] Update projects_to_test lists

03cd3f2

- Based on recent tests that were enabled on TheRock repo, updating the `projects_to_test` entries for different projects.

jayhawk-commits requested review from ammallya, geomin12, jbonnell-amd, lumachad and rahulc-gh March 4, 2026 18:32

github-actions Bot added the github actions Pull requests that update GitHub Actions code label Mar 4, 2026

jbonnell-amd reviewed Mar 4, 2026

View reviewed changes

systems-assistant Bot added the organization: ROCm label Mar 4, 2026

Test against ROCm/TheRock##3768

4ba5601

Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…

08301b6

…rch4

geomin12 approved these changes Mar 5, 2026

View reviewed changes

Comment thread .github/scripts/therock_matrix.py

jayhawk-commits and others added 4 commits March 5, 2026 17:55

Revert "Test against ROCm/TheRock##3768"

ff54fa4

This reverts commit 4ba5601.

Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…

02482ae

…rch4

Add Setup Additional Requirements step for component Python deps

3022915

Made-with: Cursor

Merge branch 'users/jayhawk-commits/projects_to_test_march4' of https…

3c12cd4

…://github.com/ROCm/rocm-systems into users/jayhawk-commits/projects_to_test_march4

Fixes for hip-tests and skip rocgdb tests for now

1416156

Forgot rocgdb occurrence

9d3926f

jayhawk-commits and others added 3 commits March 6, 2026 11:37

Update TheRock SHA to 20260306 commit

f40dc34

Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…

7a39ec6

…rch4

Fix spacing between ref and comment

a9d3b01

Merge branch 'users/jayhawk-commits/projects_to_test_march4' of githu…

4a7a0bf

…b.com:ROCm/rocm-systems into users/jayhawk-commits/projects_to_test_march4

Merge branch 'develop' into users/jayhawk-commits/projects_to_test_ma…

f204347

…rch4

jayhawk-commits requested a review from jbonnell-amd March 6, 2026 21:19

jayhawk-commits marked this pull request as ready for review March 6, 2026 21:56

jayhawk-commits requested a review from a team as a code owner March 6, 2026 21:56

Copilot AI review requested due to automatic review settings March 6, 2026 21:56

Copilot started reviewing on behalf of jayhawk-commits March 6, 2026 21:59 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

Comment thread .github/workflows/therock-test-component.yml

Comment thread .github/scripts/therock_matrix.py

Comment thread .github/scripts/therock_matrix.py

jayhawk-commits merged commit a0712d4 into develop Mar 6, 2026
30 of 33 checks passed

jayhawk-commits deleted the users/jayhawk-commits/projects_to_test_march4 branch March 6, 2026 22:03

jayhawk-commits mentioned this pull request Mar 6, 2026

Revert "[TheRock CI] rocm-systems build full ROCm stack" #3764

Closed

Conversation

jayhawk-commits commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jbonnell-amd Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

rahulc-gh Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

jbonnell-amd Mar 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jayhawk-commits commented Mar 4, 2026

Uh oh!

jayhawk-commits commented Mar 4, 2026

Uh oh!

geomin12 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbonnell-amd commented Mar 5, 2026

Uh oh!

jayhawk-commits commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayhawk-commits commented Mar 6, 2026

Uh oh!

jayhawk-commits commented Mar 6, 2026

Uh oh!

jayhawk-commits commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lumachad commented Mar 6, 2026

Uh oh!

jayhawk-commits commented Mar 6, 2026

Uh oh!

lumachad commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayhawk-commits commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jayhawk-commits commented Mar 6, 2026

Uh oh!

jayhawk-commits commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jayhawk-commits commented Mar 4, 2026 •

edited

Loading

geomin12 left a comment •

edited

Loading

jayhawk-commits commented Mar 5, 2026 •

edited

Loading

jayhawk-commits commented Mar 6, 2026 •

edited

Loading

lumachad commented Mar 6, 2026 •

edited

Loading

jayhawk-commits commented Mar 6, 2026 •

edited

Loading

jayhawk-commits commented Mar 6, 2026 •

edited

Loading